[Intel-gfx] [RFC] drm: Do not call drm_probe_ddc() when connector force isn't specified

Harish Chegondi harish.chegondi at intel.com
Thu Jun 6 07:38:00 UTC 2019


This would allow the EDID override to be handled correctly in
drm_do_get_edid() for cases where EDID data is missing or corrupt.

All drm_probe_ddc() does is call drm_do_probe_ddc_edid( , , , 1)
which probes the display by reading 1 byte of EDID data via I2C.
This patch removes the call to drm_probe_ddc() from drm_get_edid()
but drm_get_edid() calls drm_do_get_edid() which first handles
the EDID override case and then calls
drm_do_probe_ddc_edid( , , ,EDID_LENGTH) via function pointer
argument get_edid_block. So, the display device is still being
probed by reading EDID_LENGTH bytes of EDID data via I2C.

Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Signed-off-by: Harish Chegondi <harish.chegondi at intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=107583
---
 drivers/gpu/drm/drm_edid.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index d87f574feeca..41c420706532 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1724,9 +1724,6 @@ struct edid *drm_get_edid(struct drm_connector *connector,
 	if (connector->force == DRM_FORCE_OFF)
 		return NULL;
 
-	if (connector->force == DRM_FORCE_UNSPECIFIED && !drm_probe_ddc(adapter))
-		return NULL;
-
 	edid = drm_do_get_edid(connector, drm_do_probe_ddc_edid, adapter);
 	if (edid)
 		drm_get_displayid(connector, edid);
-- 
2.21.0



More information about the Intel-gfx mailing list