[Intel-gfx] [PATCH] drm/i915: Assume combo PHY HBR3 will be inherited by future platforms

Clinton Taylor Clinton.A.Taylor at intel.com
Thu Jun 6 22:04:16 UTC 2019


Yes, this makes more sense.

Reviewed-by: Clint Taylor <Clinton.A.Taylor at intel.com>

-Clint


On 6/6/19 11:09 AM, Matt Roper wrote:
> We shouldn't assume that HBR3 on combo PHYs is an EHL-specific
> capability.  Let's follow the standard i915 convention of assuming
> future platforms will inherit all features of the latest platform.
>
> Fixes: b71438606343 ("drm/i915/ehl: Support HBR3 on EHL combo PHY")
> Cc: Manasi Navare <manasi.d.navare at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_dp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index b099a9dc28fd..4e2a06513e7d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -332,7 +332,7 @@ static int icl_max_source_rate(struct intel_dp *intel_dp)
>   	enum port port = dig_port->base.port;
>   
>   	if (intel_port_is_combophy(dev_priv, port) &&
> -	    !IS_ELKHARTLAKE(dev_priv) &&
> +	    IS_ICELAKE(dev_priv) &&
>   	    !intel_dp_is_edp(intel_dp))
>   		return 540000;
>   


More information about the Intel-gfx mailing list