[Intel-gfx] [RFC 00/12] Legacy mmio accessor macro pruning

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Jun 7 12:08:26 UTC 2019


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Since we want to stop using the legacy mmio accessors (the ones which create a
hidden dependency to having a dev_priv local) this series removes all of the
more exotic ones by converting the call sites to use the new uncore accessors.

The ones left are only the standard 32-bit ones and the _FW suffix flavour. It
will be a much bigger (more invasive) task to get rid of those.

But even though this series only results in a partial conversion, benefit is
that with removed macros there is no chance to use them by accident in new code.

Tvrtko Ursulin (12):
  drm/i915: Eliminate unused mmio accessors
  drm/i915: Convert i915_reg_read_ioctl to use explicit mmio accessors
  drm/i915: Convert icl_get_stolen_reserved to uncore mmio accessors
  drm/i915: Convert gem_record_fences to uncore mmio accessors
  drm/i915: Convert intel_read_wm_latency to uncore mmio accessors
  drm/i915: Remove I915_READ64 and I915_READ64_32x2
  drm/i915: Remove I915_READ8
  drm/i915: Remove I915_POSTING_READ_FW
  drm/i915: Remove POSTING_READ16
  drm/i915: Remove I915_WRITE_NOTRACE
  drm/i915: Remove I915_READ_NOTRACE
  drm/i915: Remove I915_READ16 and I915_WRITE16

 drivers/gpu/drm/i915/gem/i915_gem_stolen.c  |   4 +-
 drivers/gpu/drm/i915/gt/intel_engine.h      |   1 +
 drivers/gpu/drm/i915/gt/intel_ringbuffer.c  |  14 +-
 drivers/gpu/drm/i915/gvt/debugfs.c          |   4 +-
 drivers/gpu/drm/i915/gvt/firmware.c         |   5 +-
 drivers/gpu/drm/i915/i915_debugfs.c         |  37 ++---
 drivers/gpu/drm/i915/i915_drv.c             |   6 +-
 drivers/gpu/drm/i915/i915_drv.h             |  31 ----
 drivers/gpu/drm/i915/i915_gem.c             |   9 +-
 drivers/gpu/drm/i915/i915_gpu_error.c       | 116 ++++++++-------
 drivers/gpu/drm/i915/i915_irq.c             |  42 +++---
 drivers/gpu/drm/i915/i915_pmu.c             |   8 +-
 drivers/gpu/drm/i915/intel_crt.c            |  41 +++---
 drivers/gpu/drm/i915/intel_dp.c             |  43 +++---
 drivers/gpu/drm/i915/intel_gmbus.c          |  53 ++++---
 drivers/gpu/drm/i915/intel_guc_submission.c |   4 +-
 drivers/gpu/drm/i915/intel_pm.c             | 149 +++++++++++---------
 drivers/gpu/drm/i915/intel_uncore.c         |  23 +--
 18 files changed, 322 insertions(+), 268 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list