[Intel-gfx] [PATCH] drm/i915: Move i915_check_and_clear_faults to intel_reset.c

Chris Wilson chris at chris-wilson.co.uk
Fri Jun 7 12:14:00 UTC 2019


Quoting Tvrtko Ursulin (2019-06-07 12:59:32)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> The code is logically about reset so it makes sense.
> 
> It also enables making i915_clear_error_registers static.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>

Yup, looks like a step in the right direction.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I can't decide just quite how it should look between the engines
sanitizing the stray errors, or if we should do an intel_reset_init /
intel_reset_sanitize pass.
-Chris


More information about the Intel-gfx mailing list