[Intel-gfx] [PATCH 3/9] drm/i915/gtt: Introduce init_pd_with_page

[Chris Wilson]

Quoting Mika Kuoppala (2019-06-11 18:27:25)
> We set the page directory entries to point into a page table.
> There is no gen specifics in here so make it simple and
> obvious.
> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 9a1f956a817a..9d87f0fb5b16 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -724,12 +724,12 @@ static void free_pd(struct i915_address_space *vm,
>         kfree(pd);
>  }
>  
> -static void gen8_initialize_pd(struct i915_address_space *vm,
> -                              struct i915_page_directory *pd)
> +static void init_pd_with_page(struct i915_address_space *vm,
> +                             struct i915_page_directory * const pd,
> +                             struct i915_page_table *pt)
>  {
> -       fill_px(vm, pd,
> -               gen8_pde_encode(px_dma(vm->scratch_pt), I915_CACHE_LLC));
> -       memset_p(pd->entry, vm->scratch_pt, I915_PDES);
> +       fill_px(vm, pd, gen8_pde_encode(px_dma(pt), I915_CACHE_LLC));

Ahem, the scratch_pte value is known apriori and doesn't need
recomputing?
-Chris