[Intel-gfx] [PATCH] drm/i915: kerneldoc warnings squelched

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Jun 12 15:25:31 UTC 2019


On Wed, Jun 12, 2019 at 04:13:11PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Function parameter or member 'shrink' not described in 'i915_gem_shrink'
> drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Excess function parameter 'flags' description in 'i915_gem_shrink'
> 
> drivers/gpu/drm/i915//intel_display.c:13443: warning: Function parameter or member '_state' not described in 'intel_atomic_check'
> drivers/gpu/drm/i915//intel_display.c:13443: warning: Excess function parameter 'state' description in 'intel_atomic_check'
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +-
>  drivers/gpu/drm/i915/intel_display.c         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> index 1b93bc334630..e15f37bef36a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
> @@ -114,7 +114,7 @@ static void try_to_writeback(struct drm_i915_gem_object *obj,
>   * @i915: i915 device
>   * @target: amount of memory to make available, in pages
>   * @nr_scanned: optional output for number of pages scanned (incremental)
> - * @flags: control flags for selecting cache types
> + * @shrink: control flags for selecting cache types
>   *
>   * This function is the main interface to the shrinker. It will try to release
>   * up to @target pages of main memory backing storage from buffer objects.
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1b1ddb48ca7a..e681ed99cdf2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13436,7 +13436,7 @@ static int calc_watermark_data(struct intel_atomic_state *state)
>  /**
>   * intel_atomic_check - validate state object
>   * @dev: drm device
> - * @state: state to validate
> + * @_state: state to validate
>   */

Not sure most of these docs are actually useful. But too lazy to
look through all of them to check.

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

>  static int intel_atomic_check(struct drm_device *dev,
>  			      struct drm_atomic_state *_state)
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list