[Intel-gfx] [PATCH v2 1/3] drm/i915: make intel_sdvo_regs.h self-contained

[Chris Wilson]

Quoting Jani Nikula (2019-06-13 10:36:20)
> On Thu, 13 Jun 2019, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2019-06-13 09:44:14)
> >> Ensure intel_sdvo_regs.h is self-contained and remains that way.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/Makefile.header-test | 1 +
> >>  drivers/gpu/drm/i915/intel_sdvo_regs.h    | 7 +++++++
> >>  2 files changed, 8 insertions(+)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
> >> index 6ef3b647ac65..c04297ce57b4 100644
> >> --- a/drivers/gpu/drm/i915/Makefile.header-test
> >> +++ b/drivers/gpu/drm/i915/Makefile.header-test
> >> @@ -56,6 +56,7 @@ header_test := \
> >>         intel_quirks.h \
> >>         intel_runtime_pm.h \
> >>         intel_sdvo.h \
> >> +       intel_sdvo_regs.h \
> >>         intel_sideband.h \
> >>         intel_sprite.h \
> >>         intel_tv.h \
> >> diff --git a/drivers/gpu/drm/i915/intel_sdvo_regs.h b/drivers/gpu/drm/i915/intel_sdvo_regs.h
> >> index e9ba3b047f93..af02c0d21d6b 100644
> >> --- a/drivers/gpu/drm/i915/intel_sdvo_regs.h
> >> +++ b/drivers/gpu/drm/i915/intel_sdvo_regs.h
> >> @@ -24,6 +24,11 @@
> >>   *     Eric Anholt <eric at anholt.net>
> >>   */
> >>  
> >> +#ifndef __INTEL_SDVO_REGS_H__
> >> +#define __INTEL_SDVO_REGS_H__
> >> +
> >
> > #include <linux/compiler.h> or compiler_attributes.h for __packed
> >
> > Looks like random inclusion otherwise.
> >
> >> +#include <linux/types.h>
> 
> Huh, no errors about __packed that I could see, what am I missing?
> <linux/types.h> is for kernel unsigned types.

Nothing, I think it gets accidentally included :)

#include <linux/compiler.h> seems to the be common choice for
__attributes.

Or you could argue that __packed is naturally a type attribute and so
should be pulled in via types.h :)
-Chris