[Intel-gfx] [RFC 06/28] drm/i915: Convert i915_gem_init_swizzling to intel_gt

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 13 13:49:00 UTC 2019


Quoting Tvrtko Ursulin (2019-06-13 14:35:17)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Start using the newly introduced struct intel_gt to fuse together correct
> logical init flow with uncore for more removal of implicit dev_priv in
> mmio access.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Looks fine, I might move it again later next to the fence registers, or
at least pull this and the detection into its own intel_gt_swizzling.c

Hmm, now that I said that, does that seem like a reasonable thing to do
right away, see i915_gem_fence_regs.c for the swizzle probe?
-Chris


More information about the Intel-gfx mailing list