[Intel-gfx] [PATCH] gpu/drm/i915: globally replace dev_priv with i915

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Jun 13 15:21:34 UTC 2019


On 13/06/2019 16:19, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 16:12:16)
>>
>> On 12/06/2019 17:29, Lucas De Marchi wrote:
>>> We are slowly converting dev_priv to i915 everywhere, spread into
>>> smaller series. While this is good to avoid unrelated breakages to other
>>> inflight patches, it's bad because inflight patches on nearby paths keep
>>> breaking. Paired with other code moves and refactores this is becoming a
>>> nightmare.
>>>
>>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>>
>> Who removed I915_READ/WRITE? In fact I see some in this patch. Well
>> colour me confused.. how did the patch compile?
> 
> The secret is in changing the implicit parameter as well, s/dev_priv/i915/

Lolz are on me. :))

Regards,

Tvrtko


More information about the Intel-gfx mailing list