[Intel-gfx] [RFC 27/28] drm/i915: Compartmentalize ring buffer creation

[Chris Wilson]

Quoting Tvrtko Ursulin (2019-06-13 16:56:37)
> 
> On 13/06/2019 16:46, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-06-13 16:19:03)
> >> @@ -1262,13 +1262,14 @@ intel_engine_create_ring(struct intel_engine_cs *engine,
> >>                           struct i915_timeline *timeline,
> >>                           int size)
> >>   {
> >> +       struct drm_i915_private *i915 = engine->i915;
> >>          struct intel_ring *ring;
> >>          struct i915_vma *vma;
> >>   
> >>          GEM_BUG_ON(!is_power_of_2(size));
> >>          GEM_BUG_ON(RING_CTL_SIZE(size) & ~RING_NR_PAGES);
> >>          GEM_BUG_ON(timeline == &engine->timeline);
> >> -       lockdep_assert_held(&engine->i915->drm.struct_mutex);
> >> +       lockdep_assert_held(&i915->drm.struct_mutex);
> > 
> > Heresy.
> 
> What why?

I don't have this line in my kernel \o/
-Chris