[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/39] drm/i915: Discard some redundant cache domain flushes

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 14 07:22:17 UTC 2019


== Series Details ==

Series: series starting with [01/39] drm/i915: Discard some redundant cache domain flushes
URL   : https://patchwork.freedesktop.org/series/62085/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6eb3b4d8d4bd drm/i915: Discard some redundant cache domain flushes
a145d1b010f1 drm/i915: Refine i915_reset.lock_map
18868d2d5f4a drm/i915: Avoid tainting i915_gem_park() with wakeref.lock
3dd6eec4d204 drm/i915: Enable refcount debugging for default debug levels
8c062ac906be drm/i915: Keep contexts pinned until after the next kernel context switch
b049d2db266c drm/i915: Stop retiring along engine
98f655113122 drm/i915: Replace engine->timeline with a plain list
-:180: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#180: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:292:
+		spinlock_t lock;

total: 0 errors, 0 warnings, 1 checks, 968 lines checked
7f8c5c0d9568 drm/i915: Flush the execution-callbacks on retiring
7960c6f7e24e drm/i915/execlists: Preempt-to-busy
-:1494: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1494: FILE: drivers/gpu/drm/i915/i915_utils.h:134:
+#define ptr_count_dec(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(--__v);					\
+} while (0)

-:1500: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_ptr' - possible side-effects?
#1500: FILE: drivers/gpu/drm/i915/i915_utils.h:140:
+#define ptr_count_inc(p_ptr) do {					\
+	typeof(p_ptr) __p = (p_ptr);					\
+	unsigned long __v = (unsigned long)(*__p);			\
+	*__p = (typeof(*p_ptr))(++__v);					\
+} while (0)

-:1783: WARNING:LINE_SPACING: Missing a blank line after declarations
#1783: FILE: drivers/gpu/drm/i915/intel_guc_submission.c:820:
+		int rem = ARRAY_SIZE(execlists->inflight) - idx;
+		memmove(execlists->inflight, port, rem * sizeof(*port));

total: 0 errors, 1 warnings, 2 checks, 1682 lines checked
4362ebfc9e11 drm/i915/execlists: Minimalistic timeslicing
-:345: WARNING:LONG_LINE: line over 100 characters
#345: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:211:
+			      2 * RUNTIME_INFO(outer->i915)->num_engines * (count + 2) * (count + 3)) < 0) {

total: 0 errors, 1 warnings, 0 checks, 426 lines checked
ee3f9dbd5dad drm/i915/execlists: Force preemption
44c2f89f62fa dma-fence: Propagate errors to dma-fence-array container
e7d5c4f25cec dma-fence: Report the composite sync_file status
2cdad69a45fb dma-fence: Refactor signaling for manual invocation
-:33: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

-:38: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#38: FILE: drivers/dma-buf/dma-fence-trace.c:1:
+/*

-:293: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#293: FILE: include/linux/dma-fence-types.h:1:
+/*

-:368: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#368: FILE: include/linux/dma-fence-types.h:76:
+	spinlock_t *lock;

total: 0 errors, 3 warnings, 1 checks, 728 lines checked
e171ea0e2acb dma-fence: Always execute signal callbacks
47a81f170456 drm/i915: Execute signal callbacks from no-op i915_request_wait
1cedd186a982 drm/i915: Make the semaphore saturation mask global
5da6a4163753 drm/i915: Throw away the active object retirement complexity
15e64af9e592 drm/i915: Provide an i915_active.acquire callback
-:684: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#684: FILE: drivers/gpu/drm/i915/i915_active_types.h:36:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 730 lines checked
0dbf4afec759 drm/i915: Push the i915_active.retire into a worker
655970ed13db drm/i915/overlay: Switch to using i915_active tracking
b03c66bab792 drm/i915: Forgo last_fence active request tracking
55e795c76331 drm/i915: Extract intel_frontbuffer active tracking
9ca5f25a8498 drm/i915: Coordinate i915_active with its own mutex
e7f6cb7712a2 drm/i915: Track ggtt fence reservations under its own mutex
2e2f11bbd4d9 drm/i915: Only track bound elements of the GTT
3576e88429ca drm/i915: Explicitly cleanup initial_plane_config
fb28ad5a502c initial-plane-vma
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:389: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 349 lines checked
ce0da27c91c2 drm/i915: Make i915_vma track its own kref
-:308: WARNING:BRACES: braces {} are not necessary for single statement blocks
#308: FILE: drivers/gpu/drm/i915/gem/selftests/huge_pages.c:576:
+		if (!IS_ERR(vma)) {
+			i915_vma_put(vma);
+		}

-:1346: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 1136 lines checked
273465acf85c drm/i915: Propagate fence errors
e73a45e0f5a1 drm/i915: Allow page pinning to be in the background
94c97e5b13b7 drm/i915: Allow vma binding to occur asynchronously
07310921ddea revoke-fence
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:233: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 186 lines checked
95f33c091ed7 drm/i915: Use vm->mutex for serialising GTT insertion
1174540f83b8 drm/i915: Pin pages before waiting
cf576994e16e drm/i915: Use reservation_object to coordinate userptr get_pages()
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 1104 lines checked
2c181cb942b4 drm/i915: Use forced preemptions in preference over hangcheck
6a167522e758 drm/i915: Remove logical HW ID
e676c08b2ebc active-rings
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:533: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 440 lines checked



More information about the Intel-gfx mailing list