[Intel-gfx] [PATCH 04/39] drm/i915: Enable refcount debugging for default debug levels

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Jun 14 15:11:12 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> refcount_t is our first line of defence against use-after-free, so let's
> enable it for debugging.

Sure. Only wakerefs currently seems to use this tho.

Should we consider changing some atomic_t's to refcounts?

And add our own assertions? We might find places where we
could warn before hitting UINT_MAX on refcount.

-Mika

>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 09aa0f4c8bf1..8d922bb4d953 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -21,6 +21,7 @@ config DRM_I915_DEBUG
>          depends on DRM_I915
>          select DEBUG_FS
>          select PREEMPT_COUNT
> +        select REFCOUNT_FULL
>          select I2C_CHARDEV
>          select STACKDEPOT
>          select DRM_DP_AUX_CHARDEV
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list