[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for prime doc polish and ... a few cleanups

Fri Jun 14 21:02:46 UTC 2019

== Series Details ==

Series: prime doc polish and ... a few cleanups
URL   : https://patchwork.freedesktop.org/series/62135/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ca5f49bad9e3 drm/todo: Improve drm_gem_object funcs todo
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 10 lines checked
71e5858ce8df drm/gem: Unexport drm_gem_(un)pin/v(un)map
-:118: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 85 lines checked
bc90321ccc72 drm/prime: Update docs
-:377: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#377: FILE: drivers/gpu/drm/drm_prime.c:304:
+	ret = drm_prime_lookup_buf_handle(&file_priv->prime,
+			dma_buf, handle);

-:428: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#428: FILE: drivers/gpu/drm/drm_prime.c:333:
+	ret = drm_prime_add_buf_handle(&file_priv->prime,
+			dma_buf, *handle);

-:519: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#519: FILE: drivers/gpu/drm/drm_prime.c:368:
+		return -ENOSYS;

-:550: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#550: FILE: drivers/gpu/drm/drm_prime.c:519:
+		return -ENOSYS;

-:723: WARNING:LONG_LINE_COMMENT: line over 100 characters
#723: FILE: drivers/gpu/drm/drm_prime.c:692:
+ * &dma_buf_ops.vunmap callback. Calls into &drm_gem_object_funcs.vunmap for device specific handling.

-:760: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#760: FILE: drivers/gpu/drm/drm_prime.c:768:
+		return -ENOSYS;

-:794: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kmalloc(sizeof(*sg)...) over kmalloc(sizeof(struct sg_table)...)
#794: FILE: drivers/gpu/drm/drm_prime.c:802:
+	sg = kmalloc(sizeof(struct sg_table), GFP_KERNEL);

-:801: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#801: FILE: drivers/gpu/drm/drm_prime.c:809:
+	ret = sg_alloc_table_from_pages(sg, pages, nr_pages, 0,
+				nr_pages << PAGE_SHIFT, GFP_KERNEL);

-:1190: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1190: FILE: include/drm/drm_drv.h:616:
+
+

-:1390: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 5 warnings, 5 checks, 1295 lines checked
6ae25bcbd4da drm/prime: Unconditionally set up the prime file private
-:57: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 36 lines checked
3709143046ea drm/prime: Make DRIVER_PRIME a no-op
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 27 lines checked
3578f6412c5a drm/prime: Actually remove DRIVER_PRIME everywhere
-:160: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.

-:163: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.

-:238: ERROR:TRAILING_WHITESPACE: trailing whitespace
#238: FILE: drivers/gpu/drm/i915/i915_drv.c:3196:
+^I    DRIVER_GEM | $

-:771: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 1 errors, 3 warnings, 0 checks, 468 lines checked
cac2708bbe8a drm/arm/komeda: Remove DRIVER_HAVE_IRQ
-:25: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
93a140f7f459 drm/omapdrm: drop fb_debug_enter/leave
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
6aff5a78c3bc drm/prime: Align gem_prime_export with obj_funcs.export
-:418: ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#418: FILE: drivers/gpu/drm/vc4/vc4_bo.c:661:
+struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)

-:486: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 1 errors, 1 warnings, 0 checks, 311 lines checked
ad7244e5ed63 drm/arc: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
e0c2f8ac23fc drm/arm: Drop drm_gem_prime_export/import
-:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
75bec2b6dc2c drm/atmel: Drop drm_gem_prime_export/import
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
0f0b7ebc239a drm/etnaviv: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
5904c7a6fe36 drm/exynos: Drop drm_gem_prime_export
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
d2309d98006b drm/fsl-dcu: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
4bd9c8d57850 drm/hisilicon: Drop drm_gem_prime_export/import
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
d7ceb9eb2b82 drm/imx: Drop drm_gem_prime_export/import
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
20f4e8ed9ba2 drm/mcde: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1f57ca76e94d drm/mtk: Drop drm_gem_prime_export/import
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
f7d0d7e5394d drm/meson: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
d6be5d3bb436 drm/msm: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
4ca065b02b5c drm/mxsfb: Drop drm_gem_prime_export/import
-:33: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
6ae41b003e3f drm/nouveau: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
e091ecdc7b24 drm/pl111: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
764c142a9894 drm/qxl: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
fb768677b579 drm/rcar-du: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
fc56ff5fe48e drm/rockchip: Drop drm_gem_prime_export/import
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
118ce892e8cf drm/shmob: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
e13d01acceb3 drm/sti: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
2389aaacfb1d drm/stm: Drop drm_gem_prime_export/import
-:33: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
ab9ae216d7f4 drm/tilcdc: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
780b51584d70 drm/tve2000: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
4289d5f68bea drm/vboxvideo: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
d91caf579098 drm/vc3: Drop drm_gem_prime_import
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
a4f6201efc57 drm/radeon: Drop drm_gem_prime_import
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
15d226ff96c3 drm/vgem: Drop drm_gem_prime_export
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
daeadffdd317 drm/virtio: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
7caaa88c8182 drm/xen: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
6a230efe3322 drm/zte: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
7a52d2d19e77 drm/vram-helper: Drop drm_gem_prime_export/import
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
23ad691e1846 drm/prime: automatically set gem_obj->resv on import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
629487211ca0 drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl
-:97: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 64 lines checked
a13da755d0fd drm/lima: Drop resv argument from lima_bo_create_struct
-:92: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
539ab5554f05 drm/mediatek: Use drm_atomic_helper_wait_for_fences
-:120: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 78 lines checked
31c23af02c92 drm/msm: Drop robj from msm_gem_new_impl
-:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 32 lines checked
8f0ae7a16036 drm/panfrost: don't set gem_obj->resv for prime import anymore
-:25: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
f604a5c0e2d5 drm/vc4: Don set gem_obj->resv in prime import anymore
-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
d6812c0d9fa7 drm/vgem: Ditch attach trickery in the fence ioctl
-:59: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 40 lines checked
5d190f4b8ca3 drm/msm: Use drm_gem_fb_prepare_fb
-:51: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 22 lines checked
4a2e82c5e29c drm/vc4: Use drm_gem_fb_prepare_fb
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 11 lines checked
459fd0284cce drm/radeon: Fill out gem_object->resv
-:77: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 34 lines checked
3f0df6263337 drm/nouveau: Fill out gem_object->resv
-:74: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 25 lines checked
b5c9965bd3d4 drm/amdgpu: Fill out gem_object->resv
-:110: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 51 lines checked
cffd8f54efae drm/prime: Ditch gem_prime_res_obj hook
-:71: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 42 lines checked
e969f8bbfc8a drm/todo: remove gem_prime_import/export todo
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 13 lines checked
c3a07f1dd6b3 drm/todo: Update backlight todo
-:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 39 lines checked
5d9607905a60 drm/todo: Update mmap todo
-:22: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1295ea404e49 drm/todo: Add new debugfs todo
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
6618e8c6c0c0 drm/doc: Document kapi doc expectations
-:66: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 38 lines checked