[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for prime doc polish and ... a few cleanups (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 17 18:28:53 UTC 2019


== Series Details ==

Series: prime doc polish and ... a few cleanups (rev2)
URL   : https://patchwork.freedesktop.org/series/62135/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9afe73fb9d83 drm/prime: Update docs
-:378: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#378: FILE: drivers/gpu/drm/drm_prime.c:304:
+	ret = drm_prime_lookup_buf_handle(&file_priv->prime,
+			dma_buf, handle);

-:429: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#429: FILE: drivers/gpu/drm/drm_prime.c:333:
+	ret = drm_prime_add_buf_handle(&file_priv->prime,
+			dma_buf, *handle);

-:520: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#520: FILE: drivers/gpu/drm/drm_prime.c:368:
+		return -ENOSYS;

-:551: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#551: FILE: drivers/gpu/drm/drm_prime.c:519:
+		return -ENOSYS;

-:724: WARNING:LONG_LINE_COMMENT: line over 100 characters
#724: FILE: drivers/gpu/drm/drm_prime.c:692:
+ * &dma_buf_ops.vunmap callback. Calls into &drm_gem_object_funcs.vunmap for device specific handling.

-:761: WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#761: FILE: drivers/gpu/drm/drm_prime.c:768:
+		return -ENOSYS;

-:795: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kmalloc(sizeof(*sg)...) over kmalloc(sizeof(struct sg_table)...)
#795: FILE: drivers/gpu/drm/drm_prime.c:802:
+	sg = kmalloc(sizeof(struct sg_table), GFP_KERNEL);

-:802: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#802: FILE: drivers/gpu/drm/drm_prime.c:809:
+	ret = sg_alloc_table_from_pages(sg, pages, nr_pages, 0,
+				nr_pages << PAGE_SHIFT, GFP_KERNEL);

-:1191: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1191: FILE: include/drm/drm_drv.h:616:
+
+

-:1391: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 5 warnings, 5 checks, 1295 lines checked
1024d696c72c drm/prime: Unconditionally set up the prime file private
-:57: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 36 lines checked
d8847d318067 drm/prime: Make DRIVER_PRIME a no-op
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 27 lines checked
3a98679addf0 drm/prime: Actually remove DRIVER_PRIME everywhere
-:164: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.

-:167: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.

-:775: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 3 warnings, 0 checks, 468 lines checked
a94a9f9a2b9d drm/arm/komeda: Remove DRIVER_HAVE_IRQ
-:25: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
5cbae9f4240b drm/omapdrm: drop fb_debug_enter/leave
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
abcb53516b96 drm/prime: Align gem_prime_export with obj_funcs.export
-:419: ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#419: FILE: drivers/gpu/drm/vc4/vc4_bo.c:661:
+struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)

-:487: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 1 errors, 1 warnings, 0 checks, 311 lines checked
61c19d49f423 drm/arc: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
61ea50e9b6ea drm/arm: Drop drm_gem_prime_export/import
-:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
f07dbf76749b drm/atmel: Drop drm_gem_prime_export/import
-:31: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
c15335ef4dbf drm/etnaviv: Drop drm_gem_prime_export/import
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
6cb1887cd7b7 drm/exynos: Drop drm_gem_prime_export
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
1691a91306ea drm/fsl-dcu: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
a170ccff1265 drm/hisilicon: Drop drm_gem_prime_export/import
-:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
5f64b4d6757b drm/imx: Drop drm_gem_prime_export/import
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
2af2f2a0d6cb drm/mcde: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
42bbcd879db8 drm/mtk: Drop drm_gem_prime_export/import
-:31: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
7bb5360b0864 drm/meson: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
87e279d74a2f drm/msm: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
749507aa7ff0 drm/mxsfb: Drop drm_gem_prime_export/import
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1fc0835d7e70 drm/nouveau: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
c1dd7aed128d drm/pl111: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
e197c119c8ce drm/qxl: Drop drm_gem_prime_export/import
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
bc1ae8995197 drm/rcar-du: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
9a09fae180e0 drm/rockchip: Drop drm_gem_prime_export/import
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
dbcc9db45235 drm/shmob: Drop drm_gem_prime_export/import
-:28: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
63dfe9ad7cdb drm/sti: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
9b515ea3b053 drm/stm: Drop drm_gem_prime_export/import
-:33: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
55dc6e929ca0 drm/tilcdc: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
01de7bf7d0c8 drm/tve2000: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
4d0b73ba00ef drm/vboxvideo: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
795a163d7741 drm/vc3: Drop drm_gem_prime_import
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
859da3befe72 drm/radeon: Drop drm_gem_prime_import
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
904e00dd5e70 drm/vgem: Drop drm_gem_prime_export
-:24: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
99d585ff885d drm/virtio: Drop drm_gem_prime_export/import
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
41656cb1c3bc drm/xen: Drop drm_gem_prime_export/import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
648300a7f270 drm/zte: Drop drm_gem_prime_export/import
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
ee9c3de26a17 drm/vram-helper: Drop drm_gem_prime_export/import
-:33: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
4383a951e45d drm/prime: automatically set gem_obj->resv on import
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 7 lines checked
14bdcb20cbc9 drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl
-:97: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 64 lines checked
9fd7ec57e316 drm/lima: Drop resv argument from lima_bo_create_struct
-:93: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
bd5c4b0ae7a0 drm/mediatek: Use drm_atomic_helper_wait_for_fences
-:121: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 78 lines checked
42b45ad6feae drm/msm: Drop robj from msm_gem_new_impl
-:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 32 lines checked
0e34626c9253 drm/panfrost: don't set gem_obj->resv for prime import anymore
-:26: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
0b72bd575151 drm/vc4: Don set gem_obj->resv in prime import anymore
-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
3eeb775108b4 drm/vgem: Ditch attach trickery in the fence ioctl
-:59: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 40 lines checked
f4b731dc47e1 drm/msm: Use drm_gem_fb_prepare_fb
-:51: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 22 lines checked
25e53b728605 drm/vc4: Use drm_gem_fb_prepare_fb
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 11 lines checked
c124e191d400 drm/radeon: Fill out gem_object->resv
-:77: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 34 lines checked
a4ca739c5fb9 drm/nouveau: Fill out gem_object->resv
-:74: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 25 lines checked
b1bc475402d2 drm/amdgpu: Fill out gem_object->resv
-:110: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 51 lines checked
bb7bff7b3c21 drm/prime: Ditch gem_prime_res_obj hook
-:71: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 42 lines checked
1246898dbc89 drm/todo: remove gem_prime_import/export todo
-:27: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 13 lines checked
e3d33a837d10 drm/todo: Update backlight todo
-:56: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 39 lines checked
46f56a74b7de drm/todo: Update mmap todo
-:22: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
377f36106503 drm/todo: Add new debugfs todo
-:25: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
a5e756db226f drm/doc: Document kapi doc expectations
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 38 lines checked



More information about the Intel-gfx mailing list