[Intel-gfx] [PATCH 01/26] drm/i915: Keep engine alive as we retire the context

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Jun 18 14:08:32 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2019-06-18 14:45:45)
>> Chris Wilson <chris at chris-wilson.co.uk> writes:
>> > @@ -328,6 +345,7 @@ void i915_active_acquire_barrier(struct i915_active *ref)
>> >  
>> >               llist_add((struct llist_node *)&node->base.link,
>> >                         &engine->barrier_tasks);
>> > +             intel_engine_pm_put(engine);
>> 
>> But you said that you keep the wakeref until unpin?
>
> intel_context_unpin ->
>   intel_context_active_release ->
>     i915_active_acquire_barrier

Not the first time I trip on the naming in here.
But I don't have better suggestions.

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>


More information about the Intel-gfx mailing list