[Intel-gfx] [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 18 16:32:33 UTC 2019


Quoting Mika Kuoppala (2019-06-18 17:17:29)
> For all page directory entries, the pde encoding is
> identical. Don't compilicate call sites with different
> versions of doing the same thing. We check the existence of
> physical page before writing the entry into it. This further
> generalizes the pd so that manipulation in callsites will be
> identical, removing the need to handle pdps differently for gen8.

And we can pull in the atomic_inc as well? At the top level the result
goes unused, but since we should not be as frequently inserting new
pages the higher up we go, that should be insignificant.
-Chris


More information about the Intel-gfx mailing list