[Intel-gfx] [PATCH 04/26] drm/i915: Flush the execution-callbacks on retiring

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 19 13:18:00 UTC 2019


Quoting Mika Kuoppala (2019-06-19 14:12:46)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > In the unlikely case the request completes while we regard it as not even
> > executing on the GPU (see the next patch!), we have to flush any pending
> > execution callbacks at retirement and ensure that we do not add any
> > more.
> >
> 
> I did see the next patch. Looked like a mountain.
> 
> Well we don't lose warnings and we should never see
> a precompleted request with current codebase so,

That is very true. I had a little freak out when I found the race, and
believed a sigh of relief on realising it only affected the next path.
-Chris


More information about the Intel-gfx mailing list