[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Display uncore prep patches (rev2)

[Patchwork]

== Series Details ==

Series: Display uncore prep patches (rev2)
URL   : https://patchwork.freedesktop.org/series/62232/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d925fdfca22c drm/i915: use vfuncs for reg_read/write_fw_domains
-:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#62: FILE: drivers/gpu/drm/i915/intel_uncore.c:1155:
+#define __gen_reg_read_funcs(func) \
+static enum forcewake_domains \
+func##_reg_read_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \
+	return __##func##_reg_read_fw_domains(uncore, i915_mmio_reg_offset(reg)); \
+} \
+\
+__gen_read(func, 8) \
+__gen_read(func, 16) \
+__gen_read(func, 32) \
+__gen_read(func, 64)

-:85: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#85: FILE: drivers/gpu/drm/i915/intel_uncore.c:1231:
 }
+__gen6_write(8)

-:116: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#116: FILE: drivers/gpu/drm/i915/intel_uncore.c:1247:
+#define __gen_reg_write_funcs(func) \
+static enum forcewake_domains \
+func##_reg_write_fw_domains(struct intel_uncore *uncore, i915_reg_t reg) { \
+	return __##func##_reg_write_fw_domains(uncore, i915_mmio_reg_offset(reg)); \
+} \
+\
+__gen_write(func, 8) \
+__gen_write(func, 16) \
+__gen_write(func, 32)

-:135: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#135: FILE: drivers/gpu/drm/i915/intel_uncore.c:1265:
+#define ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, x) \
 do { \
 	(uncore)->funcs.mmio_writeb = x##_write8; \
 	(uncore)->funcs.mmio_writew = x##_write16; \
 	(uncore)->funcs.mmio_writel = x##_write32; \
 } while (0)

-:143: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#143: FILE: drivers/gpu/drm/i915/intel_uncore.c:1272:
+#define ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x) \
 do { \
 	(uncore)->funcs.mmio_readb = x##_read8; \
 	(uncore)->funcs.mmio_readw = x##_read16; \

-:151: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#151: FILE: drivers/gpu/drm/i915/intel_uncore.c:1280:
+#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \
+do { \
+	ASSIGN_RAW_WRITE_MMIO_VFUNCS((uncore), x); \
+	(uncore)->funcs.write_fw_domains = x##_reg_write_fw_domains; \
+} while (0)

-:157: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#157: FILE: drivers/gpu/drm/i915/intel_uncore.c:1286:
+#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \
+do { \
+	ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, x); \
+	(uncore)->funcs.read_fw_domains = x##_reg_read_fw_domains; \
+} while (0)

total: 0 errors, 0 warnings, 7 checks, 258 lines checked
64e9e429a365 drm/i915: kill uncore_sanitize
a33912a9c7bb drm/i915: kill uncore_to_i915
7c1c30e3557c drm/i915: skip forcewake actions on forcewake-less uncore
-:246: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#246: FILE: drivers/gpu/drm/i915/intel_uncore.c:1691:
+		iosf_mbi_unregister_pmic_bus_access_notifier_unlocked(

total: 0 errors, 0 warnings, 1 checks, 224 lines checked
6186c2ceab1a drm/i915: dynamically allocate forcewake domains
776298c3ec6b drm/i915/gvt: decouple check_vgpu() from uncore_init()