[Intel-gfx] [PATCH v2 4/6] drm/i915: skip forcewake actions on forcewake-less uncore

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 20 07:43:58 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-06-20 02:00:19)
> We always call some of the setup/cleanup functions for forcewake, even
> if the feature is not actually available. Skipping these operations if
> forcewake is not available saves us some operations on older gens and
> prepares us for having a forcewake-less display uncore.
> 
> v2: do not make suspend/resume functions forcewake-specific (Chris,
> Tvrtko), use GEM_BUG_ON in internal forcewake-only functions (Tvrtko)
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>

That looked ok to me, I don't have to relearn everything just yet :)

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list