[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm: Pretty print mode flags

Patchwork patchwork at emeril.freedesktop.org
Thu Jun 20 22:04:08 UTC 2019


== Series Details ==

Series: series starting with [1/2] drm: Pretty print mode flags
URL   : https://patchwork.freedesktop.org/series/62475/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fb5a6b111c59 drm: Pretty print mode flags
-:119: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#119: FILE: drivers/gpu/drm/drm_modes.c:84:
+#define MODE_STR(x) [DRM_MODE_FLAG_3D_ ## x >> 14] = #x

-:134: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#134: FILE: drivers/gpu/drm/drm_modes.c:99:
+#define MODE_STR(x) [DRM_MODE_FLAG_PIC_AR_ ## x >> 19] = #x

-:522: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#522: FILE: include/drm/drm_modes.h:446:
+#define DRM_MODE_ARG(m, b) \
 	(m)->name, (m)->vrefresh, (m)->clock, \
 	(m)->hdisplay, (m)->hsync_start, (m)->hsync_end, (m)->htotal, \
 	(m)->vdisplay, (m)->vsync_start, (m)->vsync_end, (m)->vtotal, \
+	(m)->type, (m)->flags, \
+	drm_get_mode_flags_name(b, sizeof(b), (m)->flags)

-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#522: FILE: include/drm/drm_modes.h:446:
+#define DRM_MODE_ARG(m, b) \
 	(m)->name, (m)->vrefresh, (m)->clock, \
 	(m)->hdisplay, (m)->hsync_start, (m)->hsync_end, (m)->htotal, \
 	(m)->vdisplay, (m)->vsync_start, (m)->vsync_end, (m)->vtotal, \
+	(m)->type, (m)->flags, \
+	drm_get_mode_flags_name(b, sizeof(b), (m)->flags)

-:522: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#522: FILE: include/drm/drm_modes.h:446:
+#define DRM_MODE_ARG(m, b) \
 	(m)->name, (m)->vrefresh, (m)->clock, \
 	(m)->hdisplay, (m)->hsync_start, (m)->hsync_end, (m)->htotal, \
 	(m)->vdisplay, (m)->vsync_start, (m)->vsync_end, (m)->vtotal, \
+	(m)->type, (m)->flags, \
+	drm_get_mode_flags_name(b, sizeof(b), (m)->flags)

total: 3 errors, 0 warnings, 2 checks, 400 lines checked
14d66c8448d1 drm: Dump mode picture aspect ratio



More information about the Intel-gfx mailing list