[Intel-gfx] [PATCH 2/2] drm/i915/gt: Fixup kerneldoc parameters

[Tvrtko Ursulin]

On 21/06/2019 14:16, Chris Wilson wrote:
>   drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Function parameter or member 'gt' not described in 'intel_mocs_init_l3cc_table'
>   drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Excess function parameter 'dev_priv' description in 'intel_mocs_init_l3cc_table'
> 
> intel_vgt_balloon/deballoon, i915_ggtt_probe_hw intel_wopcm_init_hw need
> similar treatment
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +-
>   drivers/gpu/drm/i915/i915_gem_gtt.c  | 4 ++--
>   drivers/gpu/drm/i915/i915_vgpu.c     | 4 ++--
>   drivers/gpu/drm/i915/intel_wopcm.c   | 1 +
>   4 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index d08b8f47269b..ae6cbf0d517c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -497,7 +497,7 @@ static int emit_mocs_l3cc_table(struct i915_request *rq,
>   
>   /**
>    * intel_mocs_init_l3cc_table() - program the mocs control table
> - * @dev_priv:      i915 device private
> + * @gt: the intel_gt container
>    *
>    * This function simply programs the mocs registers for the given table
>    * starting at the given address. This register set is  programmed in pairs.
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 4dbfbccfa618..90f367397656 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2934,7 +2934,7 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
>   
>   /**
>    * i915_ggtt_cleanup_hw - Clean up GGTT hardware initialization
> - * @dev_priv: i915 device
> + * @i915: i915 device
>    */
>   void i915_ggtt_cleanup_hw(struct drm_i915_private *i915)
>   {
> @@ -3530,7 +3530,7 @@ static int ggtt_probe_hw(struct i915_ggtt *ggtt, struct intel_gt *gt)
>   
>   /**
>    * i915_ggtt_probe_hw - Probe GGTT hardware location
> - * @dev_priv: i915 device
> + * @i915: i915 device
>    */
>   int i915_ggtt_probe_hw(struct drm_i915_private *i915)
>   {
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c b/drivers/gpu/drm/i915/i915_vgpu.c
> index 9916bc6159b6..dbd1fa3c7d90 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.c
> +++ b/drivers/gpu/drm/i915/i915_vgpu.c
> @@ -131,7 +131,7 @@ static void vgt_deballoon_space(struct i915_ggtt *ggtt,
>   
>   /**
>    * intel_vgt_deballoon - deballoon reserved graphics address trunks
> - * @dev_priv: i915 device private data
> + * @ggtt: the global GGTT from which we reserved earlier
>    *
>    * This function is called to deallocate the ballooned-out graphic memory, when
>    * driver is unloaded or when ballooning fails.
> @@ -172,7 +172,7 @@ static int vgt_balloon_space(struct i915_ggtt *ggtt,
>   
>   /**
>    * intel_vgt_balloon - balloon out reserved graphics address trunks
> - * @dev_priv: i915 device private data
> + * @ggtt: the global GGTT from which to reserve
>    *
>    * This function is called at the initialization stage, to balloon out the
>    * graphic address space allocated to other vGPUs, by marking these spaces as
> diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c
> index 931987e37241..8c850785e4b4 100644
> --- a/drivers/gpu/drm/i915/intel_wopcm.c
> +++ b/drivers/gpu/drm/i915/intel_wopcm.c
> @@ -244,6 +244,7 @@ write_and_verify(struct intel_gt *gt,
>   /**
>    * intel_wopcm_init_hw() - Setup GuC WOPCM registers.
>    * @wopcm: pointer to intel_wopcm.
> + * @gt: pointer to the containing GT
>    *
>    * Setup the GuC WOPCM size and offset registers with the calculated values. It
>    * will verify the register values to make sure the registers are locked with
> 

Order is reversed in last hunk.

Thanks for fixing this up!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko