[Intel-gfx] [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

Sam Ravnborg sam at ravnborg.org
Mon Jun 24 20:39:56 UTC 2019


Hi Daniel.

> > drm_file.h:
> > - needs drm_magic_t
> >   drm_magic_t is a simple typedef, a simple unsigned int would do the trick
> 
> I think we could switch over to unsigned int for this.

OK, will send a v2 with this addressed.
There is some preparatory patches to fix build breakage when the include
file is dropped.
> 
> > drm_legacy.h
> > - needs drm_map_type and drm_map_flags. Seems legit.
> 
> enum in uapi, sweet (never do this, it's not portable across compilers,
> #defines all the way). But yeah seems legit, plus we don't care about
> drm_legacy.h
And this part I will happily ignore.
Maybe one day I will check what other dependencies there are.
On a rainy day or when there are no more users of drmP.h or so.

	Sam


More information about the Intel-gfx mailing list