[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Transcoder Port Sync feature for Tiled displays (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 24 21:27:29 UTC 2019


== Series Details ==

Series: Enable Transcoder Port Sync feature for Tiled displays (rev2)
URL   : https://patchwork.freedesktop.org/series/59837/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e1dacdba0522 drm/i915/display: Rename update_crtcs() to commit_modeset_enables()
86c171d8590a drm/i915/display: Move the commit_tail() disable sequence to commit_modeset_disables() hook
f428b4bebc07 drm/i915/display/icl: Save Master transcoder in slave's crtc_state for Transcoder Port Sync
2fedf54378a8 drm/i915/display/icl: Enable TRANSCODER PORT SYNC for tiled displays across separate ports
105509334ec9 drm/i915/display/icl: HW state readout for transcoder port sync config
-:39: CHECK:BRACES: braces {} should be used on all arms of this statement
#39: FILE: drivers/gpu/drm/i915/display/intel_display.c:10283:
+	if (trans_port_sync & PORT_SYNC_MODE_ENABLE) {
[...]
+	} else
[...]

-:56: CHECK:BRACES: Unbalanced braces around else statement
#56: FILE: drivers/gpu/drm/i915/display/intel_display.c:10300:
+	} else

total: 0 errors, 0 warnings, 2 checks, 56 lines checked
cfc8af932092 drm/i915/display/icl: Enable master-slaves in trans port sync mode in correct order
-:146: WARNING:LONG_LINE: line over 100 characters
#146: FILE: drivers/gpu/drm/i915/display/intel_display.c:14036:
+						 &to_intel_crtc_state(old_crtc_state)->wm.skl.ddb) &&

total: 0 errors, 1 warnings, 0 checks, 263 lines checked
86a0ab130772 drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence
6aa445344e23 drm/i915/display/icl: In port sync mode disable slaves first then masters



More information about the Intel-gfx mailing list