[Intel-gfx] [PATCH v2] drm/i915: Refine eDP aux backlight enable/disable sequence

Lee Shawn C shawn.c.lee at intel.com
Tue Jun 25 15:35:10 UTC 2019


Modify aux backlight enable/disable sequence just like what we
did for genernal eDP panel. Setup PWM freq and brightness level
before enable display backlight.

v2: According to spec, it is not necessary to set PWM to 0 if
    backlight enable already off. Remove intel_dp_aux_set_backlight to 0.

Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Jose Roberto de Souza <jose.souza at intel.com>
Cc: Cooper Chiou <cooper.chiou at intel.com>

Signed-off-by: Lee Shawn C <shawn.c.lee at intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 6b0b73479fb8..70d9b9c9586f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -216,8 +216,8 @@ static void intel_dp_aux_enable_backlight(const struct intel_crtc_state *crtc_st
 		}
 	}
 
-	set_aux_backlight_enable(intel_dp, true);
 	intel_dp_aux_set_backlight(conn_state, connector->panel.backlight.level);
+	set_aux_backlight_enable(intel_dp, true);
 }
 
 static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old_conn_state)
-- 
2.7.4



More information about the Intel-gfx mailing list