[Intel-gfx] [PATCH] drm/i915/irq: make i945gm_vblank_work_func() static again

[Chris Wilson]

Quoting Chris Wilson (2019-06-27 11:28:37)
> Quoting Jani Nikula (2019-06-27 11:26:16)
> > On Thu, 27 Jun 2019, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > > Quoting Jani Nikula (2019-06-27 10:19:14)
> > >> The static keyword was apparently accidentally removed in commit
> > >> 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs"), leading to
> > >> sparse warning:
> > >> 
> > >> drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol
> > >> 'i945gm_vblank_work_func' was not declared. Should it be static?
> > >> 
> > >> Make the function static again.
> > >> 
> > >> Fixes: 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs")
> > >> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > >> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > >
> > > 3 people (well 2 and a robot) send patches for the same compiler
> > > warning! That means something, right?
> > 
> > That writing patches is more rewarding than reading patches written by
> > others...? ;)
> > 
> > > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> > 
> > Thanks, likewise, let's see whose patch passes CI first. Looks like your
> > patch regresses module reload. :D
> 
> Now known to cibuglog, you cheat!

I called it a draw and pushed both merged into one :)
-Chris