[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl: Gen12 csb support
Patchwork
patchwork at emeril.freedesktop.org
Thu Jun 27 20:44:56 UTC 2019
== Series Details ==
Series: drm/i915/tgl: Gen12 csb support
URL : https://patchwork.freedesktop.org/series/62890/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
72f2fb88c700 drm/i915/tgl: Gen12 csb support
-:41: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'csb_dw' may be better as '(csb_dw)' to avoid precedence issues
#41: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:168:
+#define GEN12_CTX_SWITCH_DETAIL(csb_dw) (csb_dw & 0xF) /* upper csb dword */
-:112: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ctx_away == ctx_to'
#112: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1347:
+ if ((ctx_away == ctx_to) && ctx_to_valid)
-:115: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ctx_away != ctx_to'
#115: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1350:
+ if ((ctx_away != ctx_to) && ctx_away_valid && ctx_to_valid && !new_queue)
-:118: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'switch_detail == GEN12_CTX_PREEMPTED'
#118: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1353:
+ if ((switch_detail == GEN12_CTX_PREEMPTED) || (new_queue && ctx_away_valid))
-:121: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'switch_detail == GEN12_CTX_COMPLETE'
#121: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1356:
+ if ((switch_detail == GEN12_CTX_COMPLETE) && ctx_away_valid)
total: 0 errors, 0 warnings, 5 checks, 117 lines checked
More information about the Intel-gfx
mailing list