[Intel-gfx] [PATCH] drm/i915/guc: Define GuC firmware version for Comet Lake
kbuild test robot
lkp at intel.com
Sat Jun 29 04:52:11 UTC 2019
Hi Anusha,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20190625]
[cannot apply to v5.2-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Anusha-Srivatsa/drm-i915-guc-Define-GuC-firmware-version-for-Comet-Lake/20190629-110106
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x004-201925 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:5:0,
from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from include/linux/io-mapping.h:22,
from drivers/gpu/drm/i915/i915_drv.h:36,
from drivers/gpu/drm/i915/intel_guc_fw.c:31:
drivers/gpu/drm/i915/intel_guc_fw.c: In function 'guc_fw_select':
drivers/gpu/drm/i915/intel_guc_fw.c:104:13: error: implicit declaration of function 'IS_COMETLAKE'; did you mean 'IS_COFFEELAKE'? [-Werror=implicit-function-declaration]
} else if (IS_COMETLAKE(i915)) {
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> drivers/gpu/drm/i915/intel_guc_fw.c:104:9: note: in expansion of macro 'if'
} else if (IS_COMETLAKE(i915)) {
^~
drivers/gpu/drm/i915/intel_guc_fw.c:105:7: error: implicit declaration of function 'REVID'; did you mean 'READ'? [-Werror=implicit-function-declaration]
if (REVID(dev_priv) == 5) {
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/i915/intel_guc_fw.c:105:3: note: in expansion of macro 'if'
if (REVID(dev_priv) == 5) {
^~
drivers/gpu/drm/i915/intel_guc_fw.c:105:13: error: 'dev_priv' undeclared (first use in this function); did you mean 'dev_crit'?
if (REVID(dev_priv) == 5) {
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/i915/intel_guc_fw.c:105:3: note: in expansion of macro 'if'
if (REVID(dev_priv) == 5) {
^~
drivers/gpu/drm/i915/intel_guc_fw.c:105:13: note: each undeclared identifier is reported only once for each function it appears in
if (REVID(dev_priv) == 5) {
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
drivers/gpu/drm/i915/intel_guc_fw.c:105:3: note: in expansion of macro 'if'
if (REVID(dev_priv) == 5) {
^~
cc1: some warnings being treated as errors
vim +/if +104 drivers/gpu/drm/i915/intel_guc_fw.c
> 31 #include "i915_drv.h"
32
33 #define __MAKE_GUC_FW_PATH(KEY) \
34 "i915/" \
35 __stringify(KEY##_GUC_FW_PREFIX) "_guc_" \
36 __stringify(KEY##_GUC_FW_MAJOR) "." \
37 __stringify(KEY##_GUC_FW_MINOR) "." \
38 __stringify(KEY##_GUC_FW_PATCH) ".bin"
39
40 #define SKL_GUC_FW_PREFIX skl
41 #define SKL_GUC_FW_MAJOR 32
42 #define SKL_GUC_FW_MINOR 0
43 #define SKL_GUC_FW_PATCH 3
44 #define SKL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(SKL)
45 MODULE_FIRMWARE(SKL_GUC_FIRMWARE_PATH);
46
47 #define BXT_GUC_FW_PREFIX bxt
48 #define BXT_GUC_FW_MAJOR 32
49 #define BXT_GUC_FW_MINOR 0
50 #define BXT_GUC_FW_PATCH 3
51 #define BXT_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(BXT)
52 MODULE_FIRMWARE(BXT_GUC_FIRMWARE_PATH);
53
54 #define KBL_GUC_FW_PREFIX kbl
55 #define KBL_GUC_FW_MAJOR 32
56 #define KBL_GUC_FW_MINOR 0
57 #define KBL_GUC_FW_PATCH 3
58 #define KBL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(KBL)
59 MODULE_FIRMWARE(KBL_GUC_FIRMWARE_PATH);
60
61 #define CML_GUC_FW_PREFIX cml
62 #define CML_GUC_FW_MAJOR 33
63 #define CML_GUC_FW_MINOR 0
64 #define CML_GUC_FW_PATCH 0
65 #define CML_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(KBL)
66 MODULE_FIRMWARE(CML_GUC_FIRMWARE_PATH);
67
68 #define GLK_GUC_FW_PREFIX glk
69 #define GLK_GUC_FW_MAJOR 32
70 #define GLK_GUC_FW_MINOR 0
71 #define GLK_GUC_FW_PATCH 3
72 #define GLK_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(GLK)
73 MODULE_FIRMWARE(GLK_GUC_FIRMWARE_PATH);
74
75 #define ICL_GUC_FW_PREFIX icl
76 #define ICL_GUC_FW_MAJOR 32
77 #define ICL_GUC_FW_MINOR 0
78 #define ICL_GUC_FW_PATCH 3
79 #define ICL_GUC_FIRMWARE_PATH __MAKE_GUC_FW_PATH(ICL)
80 MODULE_FIRMWARE(ICL_GUC_FIRMWARE_PATH);
81
82 static void guc_fw_select(struct intel_uc_fw *guc_fw)
83 {
84 struct intel_guc *guc = container_of(guc_fw, struct intel_guc, fw);
85 struct drm_i915_private *i915 = guc_to_i915(guc);
86
87 GEM_BUG_ON(guc_fw->type != INTEL_UC_FW_TYPE_GUC);
88
89 if (!HAS_GUC(i915))
90 return;
91
92 if (i915_modparams.guc_firmware_path) {
93 guc_fw->path = i915_modparams.guc_firmware_path;
94 guc_fw->major_ver_wanted = 0;
95 guc_fw->minor_ver_wanted = 0;
96 } else if (IS_ICELAKE(i915)) {
97 guc_fw->path = ICL_GUC_FIRMWARE_PATH;
98 guc_fw->major_ver_wanted = ICL_GUC_FW_MAJOR;
99 guc_fw->minor_ver_wanted = ICL_GUC_FW_MINOR;
100 } else if (IS_GEMINILAKE(i915)) {
101 guc_fw->path = GLK_GUC_FIRMWARE_PATH;
102 guc_fw->major_ver_wanted = GLK_GUC_FW_MAJOR;
103 guc_fw->minor_ver_wanted = GLK_GUC_FW_MINOR;
> 104 } else if (IS_COMETLAKE(i915)) {
105 if (REVID(dev_priv) == 5) {
106 guc_fw->path = CML_GUC_FIRMWARE_PATH;
107 guc_fw->major_ver_wanted = CML_GUC_FW_MAJOR;
108 guc_fw->minor_ver_wanted = CML_GUC_FW_MINOR;
109 } else {
110 guc_fw->path = KBL_GUC_FIRMWARE_PATH;
111 guc_fw->major_ver_wanted = KBL_GUC_FW_MAJOR;
112 guc_fw->minor_ver_wanted = KBL_GUC_FW_MINOR;
113 }
114 } else if (IS_KABYLAKE(i915) || IS_COFFEELAKE(i915)) {
115 guc_fw->path = KBL_GUC_FIRMWARE_PATH;
116 guc_fw->major_ver_wanted = KBL_GUC_FW_MAJOR;
117 guc_fw->minor_ver_wanted = KBL_GUC_FW_MINOR;
118 } else if (IS_BROXTON(i915)) {
119 guc_fw->path = BXT_GUC_FIRMWARE_PATH;
120 guc_fw->major_ver_wanted = BXT_GUC_FW_MAJOR;
121 guc_fw->minor_ver_wanted = BXT_GUC_FW_MINOR;
122 } else if (IS_SKYLAKE(i915)) {
123 guc_fw->path = SKL_GUC_FIRMWARE_PATH;
124 guc_fw->major_ver_wanted = SKL_GUC_FW_MAJOR;
125 guc_fw->minor_ver_wanted = SKL_GUC_FW_MINOR;
126 }
127 }
128
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30185 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190629/ae03c8b9/attachment-0001.gz>
More information about the Intel-gfx
mailing list