[Intel-gfx] [PATCH 16/38] drm/i915: Introduce a context barrier callback

Chris Wilson chris at chris-wilson.co.uk
Sat Mar 2 10:01:03 UTC 2019


Quoting Tvrtko Ursulin (2019-03-01 16:12:33)
> 
> On 01/03/2019 14:03, Chris Wilson wrote:
> > +I915_SELFTEST_DECLARE(static unsigned long context_barrier_inject_fault);
> > +static int context_barrier_task(struct i915_gem_context *ctx,
> > +                             unsigned long engines,
> 
> I'm in two minds about usefulness of intel_engine_mask_t.

I'm thinking if we store it in a struct, then yes, always use
intel_engine_mask_t. For function parameters, the natural type is
unsigned long and we have some time before worrying about the lack of
bits. So it's a problem for future self and I'm ambivalent about the
need to enforce it just yet.
-Chris


More information about the Intel-gfx mailing list