[Intel-gfx] [PATCH 28/38] drm/i915: Store the intel_context_ops in the intel_engine_cs

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 5 16:45:32 UTC 2019


Quoting Tvrtko Ursulin (2019-03-05 16:27:34)
> 
> On 01/03/2019 14:03, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_engine_types.h b/drivers/gpu/drm/i915/intel_engine_types.h
> > index 5ec6e72d0ffb..546b790871ad 100644
> > --- a/drivers/gpu/drm/i915/intel_engine_types.h
> > +++ b/drivers/gpu/drm/i915/intel_engine_types.h
> > @@ -351,6 +351,7 @@ struct intel_engine_cs {
> >   
> >       void            (*set_default_submission)(struct intel_engine_cs *engine);
> >   
> > +     const struct intel_context_ops *context;
> 
> Calling ce_ops / context_ops / hw_context_ops ? Anything but context! :)

cops.

> > -     engine->context_pin = intel_ring_context_pin;
> > +     engine->context = &ring_context_ops;
> > +     engine->context_pin = ring_context_pin;
> 
> Consolidate context pin into ops?

In the next-but-one patch you get your wish.
-Chris


More information about the Intel-gfx mailing list