[Intel-gfx] [PATCH 1/3] drm/i915/gen11+: First assume next platforms will inherit stuff

Lucas De Marchi lucas.demarchi at intel.com
Tue Mar 5 18:36:43 UTC 2019


On Tue, Mar 05, 2019 at 05:43:15PM +0000, Tvrtko Ursulin wrote:
>>diff --git a/drivers/gpu/drm/i915/intel_mocs.c b/drivers/gpu/drm/i915/intel_mocs.c
>>index 331e7a678fb7..79913b06f455 100644
>>--- a/drivers/gpu/drm/i915/intel_mocs.c
>>+++ b/drivers/gpu/drm/i915/intel_mocs.c
>>@@ -252,7 +252,7 @@ static bool get_mocs_settings(struct drm_i915_private *dev_priv,
>>  {
>>  	bool result = false;
>>-	if (IS_ICELAKE(dev_priv)) {
>>+	if (INTEL_GEN(dev_priv) >= 11) {
>>  		table->size  = ARRAY_SIZE(icelake_mocs_table);
>>  		table->table = icelake_mocs_table;
>>  		table->n_entries = GEN11_NUM_MOCS_ENTRIES;
>>
>
>Lucas should know if this is OK.

I prefer having it like this and later change if it's different for gen
12. It will make it more consistent on how to add a new one.

Lucas De Marchi


More information about the Intel-gfx mailing list