[Intel-gfx] [PATCH 0/5] drm/i915/icl: split pll functions

Lucas De Marchi lucas.demarchi at intel.com
Wed Mar 6 01:26:31 UTC 2019


This should achieve a similar goal as in
https://patchwork.freedesktop.org/patch/287567/?series=57116&rev=1,
decoupling the PLL ids from the type.

I actually prefer the other implementation in which we can use the
pll_info struct to store the info about the pll rather than spreading
that across several functions. It's not a strong preference though.

Anyway, this should be sufficient to allow future platforms to share
common functions.

Warning: this is only build-tested... I want to confirm if this is
the way to go.

Lucas De Marchi (5):
  drm/i915/icl: split combo and mg pll enable
  drm/i915/icl: use a function pointer for pll_write when enabling
  drm/i915/icl: split combo and mg pll disable
  drm/i915/icl: split combo and tbt pll funcs
  drm/i915/icl: remove intel_dpll_is_combophy()

 drivers/gpu/drm/i915/intel_display.c  |   3 -
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 127 ++++++++++++++++++--------
 2 files changed, 87 insertions(+), 43 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list