[Intel-gfx] [PATCH 3/3] drm/i915: Move find_active_request() to the engine

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Mar 6 14:33:33 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Tvrtko Ursulin (2019-03-05 18:13:34)
>> 
>> intel_engine.h in 3...2...1.. ;)
>
> As soon as we have a good name for the legacy submission method. At the
> moment, my favorites are:
> gen2_submission.c / legacy_submission.c (actually that's winning again)
> gen8_submission.c / execlists_submission.c
> guc_submission.c

I would favour the name of the method instead of gens. And legacy is
always sneaking steadily towards present. So how about
ringbuf_submission.c ?

-Mika

>
> intel_ring.[ch] can provide the small bit of common struct intel_ring,
> and intel_engine.[ch] for the common setup/poking.
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list