[Intel-gfx] [PATCH 09/13] drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[]

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 8 17:11:03 UTC 2019


Quoting Tvrtko Ursulin (2019-03-08 16:31:51)
> Looks okay. But one more thing is needed:
> 
> https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=media&id=38266bfe99469de9e13774a13fa641c377988c67

drm/i915: Allow SSEU configuration to be set on virtual engine

 	/* Only render engine supports RPCS configuration. */
-	if (engine->class != RENDER_CLASS)
+	if (engine->class != RENDER_CLASS &&
+	    !(engine->flags & I915_ENGINE_IS_VIRTUAL &&
+	      ctx->engines[1]->class == RENDER_CLASS))
 		return -ENODEV;

A virtual engine composed of RCS engines would have
engine->class == RENDER_CLASS.

So it's just the engine->id BUG_ON that needs lifting?
-Chris


More information about the Intel-gfx mailing list