[Intel-gfx] [PATCH 1/2] drm/i915: Sort ICL PCI IDs

[Souza, Jose]

On Fri, 2019-03-08 at 13:17 -0800, Rodrigo Vivi wrote:
> On Thu, Mar 07, 2019 at 12:56:55PM -0800, José Roberto de Souza
> wrote:
> > Lets keep it sorted to make easy to spot missing PCI IDs.
> 
> Hmm... In my opinion leaving it as the identical order
> of the spec is the way to make it easier to spot if we missed
> something...
> 
> Otherwise when reviewing I have to stop and sort one or another.

Oh it is following the order of the second table, okay makes sense keep
this way.

> 
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> > ---
> >  include/drm/i915_pciids.h | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index d2fad7b0fcf6..be735811591d 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -459,16 +459,16 @@
> >  #define INTEL_ICL_11_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x8A50, info), \
> >  	INTEL_VGA_DEVICE(0x8A51, info), \
> > -	INTEL_VGA_DEVICE(0x8A5C, info), \
> > -	INTEL_VGA_DEVICE(0x8A5D, info), \
> > -	INTEL_VGA_DEVICE(0x8A59, info),	\
> > -	INTEL_VGA_DEVICE(0x8A58, info),	\
> >  	INTEL_VGA_DEVICE(0x8A52, info), \
> > +	INTEL_VGA_DEVICE(0x8A56, info), \
> > +	INTEL_VGA_DEVICE(0x8A57, info), \
> > +	INTEL_VGA_DEVICE(0x8A58, info),	\
> > +	INTEL_VGA_DEVICE(0x8A59, info),	\
> >  	INTEL_VGA_DEVICE(0x8A5A, info), \
> >  	INTEL_VGA_DEVICE(0x8A5B, info), \
> > -	INTEL_VGA_DEVICE(0x8A57, info), \
> > -	INTEL_VGA_DEVICE(0x8A56, info), \
> > -	INTEL_VGA_DEVICE(0x8A71, info), \
> > -	INTEL_VGA_DEVICE(0x8A70, info)
> > +	INTEL_VGA_DEVICE(0x8A5C, info), \
> > +	INTEL_VGA_DEVICE(0x8A5D, info), \
> > +	INTEL_VGA_DEVICE(0x8A70, info), \
> > +	INTEL_VGA_DEVICE(0x8A71, info)
> >  
> >  #endif /* _I915_PCIIDS_H */
> > -- 
> > 2.21.0
> > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190308/645e2c9f/attachment.sig>