[Intel-gfx] [PATCH 08/39] drm/i915: Create/destroy VM (ppGTT) for use with contexts

[Chris Wilson]

Quoting Rodrigo Vivi (2019-03-13 20:11:21)
> On Wed, Mar 13, 2019 at 02:43:30PM +0000, Chris Wilson wrote:
> > +     /*
> > +      * We need to flush any requests using the current ppgtt before
> > +      * we release it as the requests do not hold a reference themselves,
> > +      * only indirectly through the context.
> > +      */
> > +     err = context_barrier_task(ctx, ALL_ENGINES,
> 
> maybe while we don't add this here we could move context_barrier_task
> to avoid breaking compilations without selftest?
> 
> drivers/gpu/drm/i915/i915_gem_context.c:698:12: warning: ‘context_barrier_task’ defined but not used [-Wunused-function]
>  static int context_barrier_task(struct i915_gem_context *ctx,

So what's your objection to this code that uses it?
-Chris