[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915: Hold a ref to the ring while retiring (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Wed Mar 13 23:03:22 UTC 2019
== Series Details ==
Series: series starting with [01/17] drm/i915: Hold a ref to the ring while retiring (rev2)
URL : https://patchwork.freedesktop.org/series/57937/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d62cd9df9172 drm/i915: Hold a ref to the ring while retiring
4a377a0ed26c drm/i915: Lock the gem_context->active_list while dropping the link
425baf413268 drm/i915: Hold a reference to the active HW context
064792100ce5 drm/i915: Stop needlessly acquiring wakeref for debugfs/drop_caches_set
f1d375f07c30 drm/i915/selftests: Provide stub reset functions
9537812e0fbb drm/i915: Switch to use HWS indices rather than addresses
467096587006 drm/i915: Introduce the i915_user_extension_method
-:70: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#70:
new file mode 100644
-:75: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#75: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1:
+/*
-:140: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#140: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1:
+/*
-:168: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#168: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({ \
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
-:168: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#168: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({ \
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
-:168: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues
#168: FILE: drivers/gpu/drm/i915/i915_utils.h:108:
+#define container_of_user(ptr, type, member) ({ \
+ void __user *__mptr = (void __user *)(ptr); \
+ BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
+ !__same_type(*(ptr), void), \
+ "pointer type mismatch in container_of()"); \
+ ((type __user *)(__mptr - offsetof(type, member))); })
-:175: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'U' - possible side-effects?
#175: FILE: drivers/gpu/drm/i915/i915_utils.h:115:
+#define check_user_mbz(U) ({ \
+ typeof(*(U)) mbz__; \
+ get_user(mbz__, (U)) ? -EFAULT : mbz__ ? -EINVAL : 0; \
+})
total: 0 errors, 3 warnings, 4 checks, 132 lines checked
f1b31528e84d drm/i915: Create/destroy VM (ppGTT) for use with contexts
-:45: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#45: FILE: drivers/gpu/drm/i915/i915_drv.h:221:
+ struct mutex vm_lock;
-:694: WARNING:LINE_SPACING: Missing a blank line after declarations
#694: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:503:
+ struct drm_file *file;
+ IGT_TIMEOUT(end_time);
-:756: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#756: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:565:
+ ncontexts = dw = 0;
-:831: WARNING:LINE_SPACING: Missing a blank line after declarations
#831: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:633:
+ struct i915_gem_context *ctx = NULL;
+ IGT_TIMEOUT(end_time);
-:901: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#901: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:686:
+ ncontexts = dw = 0;
-:1056: WARNING:LONG_LINE: line over 100 characters
#1056: FILE: include/uapi/drm/i915_drm.h:407:
+#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control)
-:1057: WARNING:LONG_LINE: line over 100 characters
#1057: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:1057: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1057: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
-:1057: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1057: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)
total: 1 errors, 5 warnings, 3 checks, 1004 lines checked
03995ebe1cda drm/i915: Extend CONTEXT_CREATE to set parameters upon construction
-:28: WARNING:LONG_LINE: line over 100 characters
#28: FILE: drivers/gpu/drm/i915/i915_drv.c:3113:
+ DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW),
-:535: WARNING:LONG_LINE: line over 100 characters
#535: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
-:535: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#535: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
-:535: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#535: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)
total: 1 errors, 3 warnings, 0 checks, 694 lines checked
a60ae2cf83e0 drm/i915: Allow contexts to share a single timeline across all engines
bf975e154c20 drm/i915: Allow userspace to clone contexts on creation
8ff51d7f4412 drm/i915: Allow a context to define its set of engines
-:448: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'T' - possible side-effects?
#448: FILE: drivers/gpu/drm/i915/i915_utils.h:94:
+#define check_struct_size(T, A, C, SZ) \
+ likely(__check_struct_size(sizeof(*(T)), \
+ sizeof(*(T)->A) + __must_be_array((T)->A), \
+ C, SZ))
-:448: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'A' - possible side-effects?
#448: FILE: drivers/gpu/drm/i915/i915_utils.h:94:
+#define check_struct_size(T, A, C, SZ) \
+ likely(__check_struct_size(sizeof(*(T)), \
+ sizeof(*(T)->A) + __must_be_array((T)->A), \
+ C, SZ))
-:448: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'A' may be better as '(A)' to avoid precedence issues
#448: FILE: drivers/gpu/drm/i915/i915_utils.h:94:
+#define check_struct_size(T, A, C, SZ) \
+ likely(__check_struct_size(sizeof(*(T)), \
+ sizeof(*(T)->A) + __must_be_array((T)->A), \
+ C, SZ))
total: 0 errors, 0 warnings, 3 checks, 457 lines checked
bbe22f0d1657 drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[]
ac7a61238e94 drm/i915: Load balancing across a virtual engine
-:962: WARNING:LINE_SPACING: Missing a blank line after declarations
#962: FILE: drivers/gpu/drm/i915/intel_lrc.c:3392:
+ struct intel_engine_cs *actual = ve->siblings[0];
+ intel_context_put(&ve->context);
total: 0 errors, 1 warnings, 0 checks, 1163 lines checked
232df8a89674 drm/i915: Extend execution fence to support a callback
12cee20f7d30 drm/i915/execlists: Virtual engine bonding
-:472: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#472: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:1318:
+ if (i915_request_wait(rq[0],
+ I915_WAIT_LOCKED,
total: 0 errors, 0 warnings, 1 checks, 558 lines checked
c68377160c45 drm/i915: Allow specification of parallel execbuf
More information about the Intel-gfx
mailing list