[Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

Vanshidhar Konda vanshidhar.r.konda at intel.com
Fri Mar 15 18:39:54 UTC 2019


Extend the timeout for the hardware to signal SEND_BUSY on the DP
Aux Channel Controller register.

This is needed to address FDO #109982
https://bugzilla.freedesktop.org/show_bug.cgi?id=109982

Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Imre Deak <imre.deak at intel.com>
Signed-off-by: Vanshidhar Konda <vanshidhar.r.konda at intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 47857f96c3b1..fd6de33c5664 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1053,6 +1053,8 @@ intel_dp_check_edp(struct intel_dp *intel_dp)
 	}
 }
 
+#define DP_AUX_CH_CTL_SIGNAL_TIMEOUT_MS 15
+
 static u32
 intel_dp_aux_wait_done(struct intel_dp *intel_dp)
 {
@@ -1063,7 +1065,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
 
 #define C (((status = I915_READ_NOTRACE(ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
 	done = wait_event_timeout(dev_priv->gmbus_wait_queue, C,
-				  msecs_to_jiffies_timeout(10));
+				  msecs_to_jiffies_timeout(DP_AUX_CH_CTL_SIGNAL_TIMEOUT_MS));
 
 	/* just trace the final value */
 	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-- 
2.20.1



More information about the Intel-gfx mailing list