[Intel-gfx] [PATCH 02/22] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h

[Tvrtko Ursulin]

On 18/03/2019 10:40, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-03-18 10:21:41)
>>
>> On 18/03/2019 09:51, Chris Wilson wrote:
>>> We want to use intel_engine_mask_t inside i915_request.h, which means
>>> extracting it from the general header file mess and placing it inside a
>>> types.h. A knock on effect is that the compiler wants to warn about
>>> type-contraction of ALL_ENGINES into intel_engine_maskt_t, so prepare
>>> for the worst.
>>
>> We can't do:
>>
>> #define ALL_ENGINES ((intel_engine_mask_t)-1)
>>
>> to avoid this warning and a lot of the churn?
> 
> The churn is a lot of type fixing which needs to be done at some point.
> I'm not keen on passing the contracted intel_engine_mask_t, and
> ALL_ENGINES is not all bits set.

It is all bit set in intel_engine_mask_t. ;) I forgot what was your 
argument against using it in function arguments. Perhaps because it is 
pointless.. I regret adding this typedef even more now.

Regards,

Tvrtko