[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915: Flush pages on acquisition

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 18 17:10:59 UTC 2019 

== Series Details ==

Series: series starting with [01/22] drm/i915: Flush pages on acquisition
URL   : https://patchwork.freedesktop.org/series/58122/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
db0c17ac314c drm/i915: Flush pages on acquisition
2f0c66c9e084 drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h
-:372: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#372: 
new file mode 100644

-:377: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#377: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:1:
+/*

-:378: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#378: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:2:
+ * SPDX-License-Identifier: MIT

-:552: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#552: FILE: drivers/gpu/drm/i915/intel_engine_types.h:37:
+#define INIT_ALL_ENGINES(x) (x) = (intel_engine_mask_t)(ALL_ENGINES)

-:598: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#598: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:1:
+/*

-:599: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#599: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:2:
+ * SPDX-License-Identifier: MIT

total: 1 errors, 5 warnings, 0 checks, 482 lines checked
760f0e1843fb drm/i915: Hold a ref to the ring while retiring
8e76f5ceca89 drm/i915: Lock the gem_context->active_list while dropping the link
9660fb957595 drm/i915: Hold a reference to the active HW context
81e4c86f7858 drm/i915/selftests: Provide stub reset functions
77e9c6071ae2 drm/i915: Switch to use HWS indices rather than addresses
7c8295cb5045 drm/i915: Separate GEM context construction and registration to userspace
6c22100b87d7 drm/i915: Introduce a mutex for file_priv->context_idr
3efbc1e0b934 drm/i915: Introduce the i915_user_extension_method
-:72: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#72: 
new file mode 100644

-:77: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#77: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1:
+/*

-:78: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#78: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:2:
+ * SPDX-License-Identifier: MIT

-:144: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#144: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1:
+/*

-:145: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#145: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:2:
+ * SPDX-License-Identifier: MIT

-:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#178: FILE: drivers/gpu/drm/i915/i915_utils.h:114:
+#define container_of_user(ptr, type, member) ({				\
+	void __user *__mptr = (void __user *)(ptr);			\
+	BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) &&	\
+			 !__same_type(*(ptr), void),			\
+			 "pointer type mismatch in container_of()");	\
+	((type __user *)(__mptr - offsetof(type, member))); })

-:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#178: FILE: drivers/gpu/drm/i915/i915_utils.h:114:
+#define container_of_user(ptr, type, member) ({				\
+	void __user *__mptr = (void __user *)(ptr);			\
+	BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) &&	\
+			 !__same_type(*(ptr), void),			\
+			 "pointer type mismatch in container_of()");	\
+	((type __user *)(__mptr - offsetof(type, member))); })

-:178: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues
#178: FILE: drivers/gpu/drm/i915/i915_utils.h:114:
+#define container_of_user(ptr, type, member) ({				\
+	void __user *__mptr = (void __user *)(ptr);			\
+	BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) &&	\
+			 !__same_type(*(ptr), void),			\
+			 "pointer type mismatch in container_of()");	\
+	((type __user *)(__mptr - offsetof(type, member))); })

-:198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'U' - possible side-effects?
#198: FILE: drivers/gpu/drm/i915/i915_utils.h:134:
+#define check_user_mbz(U) ({						\
+	typeof(*(U)) mbz__;						\
+	get_user(mbz__, (U)) ? -EFAULT : mbz__ ? -EINVAL : 0;		\
+})

total: 0 errors, 5 warnings, 4 checks, 153 lines checked
1a5d1344d0c2 drm/i915: Create/destroy VM (ppGTT) for use with contexts
-:48: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#48: FILE: drivers/gpu/drm/i915/i915_drv.h:223:
+	struct mutex vm_lock;

-:699: WARNING:LINE_SPACING: Missing a blank line after declarations
#699: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:504:
+		struct drm_file *file;
+		IGT_TIMEOUT(end_time);

-:761: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#761: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:566:
+		ncontexts = dw = 0;

-:836: WARNING:LINE_SPACING: Missing a blank line after declarations
#836: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:634:
+		struct i915_gem_context *ctx = NULL;
+		IGT_TIMEOUT(end_time);

-:912: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#912: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:693:
+		ncontexts = dw = 0;

-:1067: WARNING:LONG_LINE: line over 100 characters
#1067: FILE: include/uapi/drm/i915_drm.h:407:
+#define DRM_IOCTL_I915_GEM_VM_CREATE	DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control)

-:1068: WARNING:LONG_LINE: line over 100 characters
#1068: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY	DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)

-:1068: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1068: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY	DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)

-:1068: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1068: FILE: include/uapi/drm/i915_drm.h:408:
+#define DRM_IOCTL_I915_GEM_VM_DESTROY	DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control)

total: 1 errors, 5 warnings, 3 checks, 1009 lines checked
c81c021e9a0a drm/i915: Extend CONTEXT_CREATE to set parameters upon construction
-:28: WARNING:LONG_LINE: line over 100 characters
#28: FILE: drivers/gpu/drm/i915/i915_drv.c:3113:
+	DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW),

-:543: WARNING:LONG_LINE: line over 100 characters
#543: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT	DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)

-:543: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#543: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT	DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)

-:543: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#543: FILE: include/uapi/drm/i915_drm.h:397:
+#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT	DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext)

total: 1 errors, 3 warnings, 0 checks, 703 lines checked
b488cdbdc9b1 drm/i915: Allow contexts to share a single timeline across all engines
af709feee39c drm/i915: Allow userspace to clone contexts on creation
-:132: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#132: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1623:
+#define MAP(x, y) [ilog2(I915_CONTEXT_CLONE_##x)] = y

total: 1 errors, 0 warnings, 0 checks, 182 lines checked
58a9ba87fabc drm/i915: Allow a context to define its set of engines
-:482: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#482: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

-:482: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#482: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

-:482: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues
#482: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

total: 0 errors, 0 warnings, 3 checks, 490 lines checked
caf36e6e753f drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[]
0709f6f09616 drm/i915: Load balancing across a virtual engine
-:958: WARNING:LINE_SPACING: Missing a blank line after declarations
#958: FILE: drivers/gpu/drm/i915/intel_lrc.c:3390:
+		struct intel_engine_cs *actual = ve->siblings[0];
+		intel_context_put(&ve->context);

total: 0 errors, 1 warnings, 0 checks, 1159 lines checked
8a4e035b1017 drm/i915: Extend execution fence to support a callback
f5b2cb4a5233 drm/i915/execlists: Virtual engine bonding
a218c6d2e690 drm/i915: Allow specification of parallel execbuf

More information about the Intel-gfx mailing list