[Intel-gfx] [PATCH 3/3] drm/i915: Pass dev_priv to intel_is_dual_link_lvds()

[Chris Wilson]

Quoting Rodrigo Vivi (2019-03-19 17:31:40)
> On Tue, Mar 19, 2019 at 05:50:22PM +0200, Jani Nikula wrote:
> > On Mon, 18 Mar 2019, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> > > On Mon, Mar 18, 2019 at 09:45:16PM +0100, Michal Wajdeczko wrote:
> > >> > Make things look a bit nicer by passing dev_priv to
> > >> 
> > >> In other places we are changing naming from dev_priv to i915.
> > >> Can we do the same here ?
> > >
> > > The display code uses dev_priv quite consistently,. We could
> > > go for i915 I suppose but I'd prefer a mass conversion rather
> > > than the death by a thousand cuts approach. The display
> > > code is already messy enough when it comes to naming local
> > > variables.
> 
> As Ville I'm more in favor of the mass conversion using sed and/or
> coccinelle. It's less painful and less confusing.
> 
> > 
> > We could use i915 in display code as a convention for code that does not
> > do register access. ;)
> 
> For me this is the worst part of gem code... the mix
> of i915 and dev_priv for these cases. Something that a massive
> and global change could fix?

Yes, killing I915_READ(). If only plans were afoot...
-Chris