[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Compartmentalize uncore code (rev2)

[Patchwork]

== Series Details ==

Series: Compartmentalize uncore code (rev2)
URL   : https://patchwork.freedesktop.org/series/57962/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7eeb92fc30c1 drm/i915: always use masks on FW regs
e02d7bd59410 drm/i915: use intel_uncore in fw get/put internal paths
-:600: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tmp__' - possible side-effects?
#600: FILE: drivers/gpu/drm/i915/intel_uncore.h:131:
+#define for_each_fw_domain_masked(domain__, mask__, uncore__, tmp__) \
 	for (tmp__ = (mask__); \
+	     tmp__ ? (domain__ = &(uncore__)->fw_domain[__mask_next_bit(tmp__)]), 1 : 0;)

-:607: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore__' - possible side-effects?
#607: FILE: drivers/gpu/drm/i915/intel_uncore.h:135:
+#define for_each_fw_domain(domain__, uncore__, tmp__) \
+	for_each_fw_domain_masked(domain__, (uncore__)->fw_domains, uncore__, tmp__)

total: 0 errors, 0 warnings, 2 checks, 567 lines checked
1e88e185db7a drm/i915: use intel_uncore for all forcewake get/put
-:58: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#58: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:992:
+			intel_uncore_forcewake_get(&gvt->dev_priv->uncore,
 					FORCEWAKE_ALL);

-:67: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#67: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1014:
+			intel_uncore_forcewake_put(&gvt->dev_priv->uncore,
 					FORCEWAKE_ALL);

total: 0 errors, 0 warnings, 2 checks, 786 lines checked
a42b363d5c3f drm/i915: make more uncore function work on intel_uncore
-:191: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#191: FILE: drivers/gpu/drm/i915/intel_uncore.c:1308:
+#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \
 do { \
+	(uncore)->funcs.mmio_writeb = x##_write8; \
+	(uncore)->funcs.mmio_writew = x##_write16; \
+	(uncore)->funcs.mmio_writel = x##_write32; \
 } while (0)

-:202: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#202: FILE: drivers/gpu/drm/i915/intel_uncore.c:1315:
+#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \
 do { \
+	(uncore)->funcs.mmio_readb = x##_read8; \
+	(uncore)->funcs.mmio_readw = x##_read16; \
+	(uncore)->funcs.mmio_readl = x##_read32; \
+	(uncore)->funcs.mmio_readq = x##_read64; \
 } while (0)

-:414: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects?
#414: FILE: drivers/gpu/drm/i915/intel_uncore.c:1499:
+#define ASSIGN_FW_DOMAINS_TABLE(uncore, d) \
 { \
+	(uncore)->fw_domains_table = \
 			(struct intel_forcewake_range *)(d); \
+	(uncore)->fw_domains_table_entries = ARRAY_SIZE((d)); \
 }

-:414: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects?
#414: FILE: drivers/gpu/drm/i915/intel_uncore.c:1499:
+#define ASSIGN_FW_DOMAINS_TABLE(uncore, d) \
 { \
+	(uncore)->fw_domains_table = \
 			(struct intel_forcewake_range *)(d); \
+	(uncore)->fw_domains_table_entries = ARRAY_SIZE((d)); \
 }

total: 0 errors, 0 warnings, 4 checks, 583 lines checked
603b151c1f69 drm/i915: make find_fw_domain work on intel_uncore
13ecd23c0131 drm/i915: reduce the dev_priv->uncore dance in uncore.c
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#56: FILE: drivers/gpu/drm/i915/intel_uncore.c:885:
+#define __fwtable_reg_read_fw_domains(uncore, offset) \
 ({ \
 	enum forcewake_domains __fwd = 0; \
 	if (NEEDS_FORCE_WAKE((offset))) \
+		__fwd = find_fw_domain(uncore, offset); \
 	__fwd; \
 })

-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/intel_uncore.c:893:
+#define __gen11_fwtable_reg_read_fw_domains(uncore, offset) \
 ({ \
 	enum forcewake_domains __fwd = 0; \
 	if (GEN11_NEEDS_FORCE_WAKE((offset))) \
+		__fwd = find_fw_domain(uncore, offset); \
 	__fwd; \
 })

-:80: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#80: FILE: drivers/gpu/drm/i915/intel_uncore.c:949:
+#define __gen8_reg_write_fw_domains(uncore, offset) \
 ({ \
 	enum forcewake_domains __fwd; \
 	if (NEEDS_FORCE_WAKE(offset) && !is_gen8_shadowed(offset)) \

-:89: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#89: FILE: drivers/gpu/drm/i915/intel_uncore.c:979:
+#define __fwtable_reg_write_fw_domains(uncore, offset) \
 ({ \
 	enum forcewake_domains __fwd = 0; \
 	if (NEEDS_FORCE_WAKE((offset)) && !is_gen8_shadowed(offset)) \
+		__fwd = find_fw_domain(uncore, offset); \
 	__fwd; \
 })

-:99: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects?
#99: FILE: drivers/gpu/drm/i915/intel_uncore.c:987:
+#define __gen11_fwtable_reg_write_fw_domains(uncore, offset) \
 ({ \
 	enum forcewake_domains __fwd = 0; \
 	if (GEN11_NEEDS_FORCE_WAKE((offset)) && !is_gen11_shadowed(offset)) \
+		__fwd = find_fw_domain(uncore, offset); \
 	__fwd; \
 })

total: 0 errors, 0 warnings, 5 checks, 252 lines checked
4c09e145044b drm/i915: move regs pointer inside the uncore structure
-:302: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!uncore->regs"
#302: FILE: drivers/gpu/drm/i915/intel_uncore.c:1562:
+	if (uncore->regs == NULL) {

-:319: CHECK:LINE_SPACING: Please don't use multiple blank lines
#319: FILE: drivers/gpu/drm/i915/intel_uncore.c:1579:
+
+

total: 0 errors, 0 warnings, 2 checks, 307 lines checked
dfd2240515bb drm/i915: make raw access function work on uncore
-:93: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#93: FILE: drivers/gpu/drm/i915/intel_uncore.c:34:
+#define __raw_posting_read(uncore__, reg__) (void)__raw_i915_read32((uncore__), (reg__))

-:159: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#159: FILE: drivers/gpu/drm/i915/intel_uncore.c:326:
+		if (wait_for_atomic((n = fifo_free_entries(uncore)) >

total: 2 errors, 0 warnings, 0 checks, 337 lines checked
09373cd53e61 drm/i915: add uncore flags
d3c15f3a0fd8 drm/i915: switch uncore mmio funcs to use intel_uncore