[Intel-gfx] [PATCH v2 00/10] Compartmentalize uncore code

[Chris Wilson]

Quoting Chris Wilson (2019-03-19 18:59:04)
> Quoting Daniele Ceraolo Spurio (2019-03-19 18:35:33)
> > Compared to v1 [1], there is a new patch for further simplification of
> > low-level fw get/put by always using the bitmasks since the upper bits
> > of the fw reg are reserved on gen6 and I couldn't find any reason
> > writing them wouldn't work in the git history.
> > I put together a small selftest to trybot this on snb [2], if people
> > think it is worth adding it to the tree I can clean it up and send it
> > for review.
> > 
> > Apart from the above, addresses the review comments, the only
> > non-trivial one being moving the mmio setup under uncore.
> > 
> > [1] https://patchwork.freedesktop.org/series/57962/
> > [2] https://patchwork.freedesktop.org/patch/292852/?series=58159&rev=1
> 
> I thought so. You just need to verify that the fw count is zero at the
> start of the loop and then flush the hrtimer instead of the imprecise
> usleep().

After beating around the bush to find the right mix of registers that
give us the inspection we need, I've pushed your selftest. Hopefully
that holds up to soak testing and provides a nice early warning canary.
Thanks,
-Chris