[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 21 18:58:05 UTC 2019


Quoting Chris Wilson (2019-03-21 18:38:53)
> Quoting Caz Yokoyama (2019-03-21 18:41:10)
> > inline
> > -caz
> > On Thu, 2019-03-21 at 07:37 +0000, Chris Wilson wrote:
> > > +
> > > +                     rq = i915_request_alloc(engine, lo.ctx);
> > > +                     if (IS_ERR(rq))
> > > +                             goto err_wedged;
> > > +                     i915_request_add(rq);
> > This request add is redundant. Wait for the last rq for lo.
> 
> Or not. And use a simple request as a flush and test.

The alternative would be to use igt_flush_test(). Some variance between
tests is good for serendipity.
-Chris


More information about the Intel-gfx mailing list