[Intel-gfx] [PATCH 0/3] Do not re-read dpll registers

Lucas De Marchi lucas.demarchi at intel.com
Thu Mar 21 22:02:54 UTC 2019


Instead of re-reading the registers we just read on the hw state
readout, use the values saved on intel_shared_dpll. Besides not doing
the MMIO, this helps on sharing code since we don't have to
differentiate e.g. ICL and CNL because they have different registers for
the same thing.

I'm a little hesitant wrt DSI. It seems we have completly different
implementations for ICL and gen <= 11. BXT has another hook so is not
affected, but I'm not sure if we have any other gens with DSI that share
the skl hooks.

Lucas De Marchi (3):
  drm/i915/skl: use previous pll hw readout
  drm/i915/cnl: use previous pll hw readout
  drm/i915/icl: use previous pll hw readout

 drivers/gpu/drm/i915/icl_dsi.c   |   5 +-
 drivers/gpu/drm/i915/intel_ddi.c | 139 +++++++++++++++----------------
 drivers/gpu/drm/i915/intel_drv.h |   2 +-
 3 files changed, 70 insertions(+), 76 deletions(-)

-- 
2.20.1



More information about the Intel-gfx mailing list