[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop storing the media fuse
Patchwork
patchwork at emeril.freedesktop.org
Fri Mar 22 02:09:59 UTC 2019
== Series Details ==
Series: drm/i915: stop storing the media fuse
URL : https://patchwork.freedesktop.org/series/58387/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
de5dfcc93c76 drm/i915: stop storing the media fuse
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'first' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'first' may be better as '(first)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'count' may be better as '(count)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:26: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#26: FILE: drivers/gpu/drm/i915/i915_drv.h:2446:
+#define VDBOX_MASK(dev_priv) ENGINE_INSTANCES_MASK(dev_priv, VCS0, I915_MAX_VCS);
-:27: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#27: FILE: drivers/gpu/drm/i915/i915_drv.h:2447:
+#define VEBOX_MASK(dev_priv) ENGINE_INSTANCES_MASK(dev_priv, VECS0, I915_MAX_VECS);
total: 0 errors, 2 warnings, 3 checks, 64 lines checked
More information about the Intel-gfx
mailing list