[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915: Report the correct errno from i915_gem_context_open()

Mon Mar 25 09:19:07 UTC 2019

== Series Details ==

Series: series starting with [01/22] drm/i915: Report the correct errno from i915_gem_context_open()
URL   : https://patchwork.freedesktop.org/series/58517/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a06b0f01cad0 drm/i915: Report the correct errno from i915_gem_context_open()
a1c4349dcef8 drm/i915/guc: Replace preempt_client lookup with engine->preempt_context
8733fc778e94 drm/i915: Pull the GEM powermangement coupling into its own file
-:417: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#417: 
new file mode 100644

-:422: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#422: FILE: drivers/gpu/drm/i915/i915_gem_pm.c:1:
+/*

-:423: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#423: FILE: drivers/gpu/drm/i915/i915_gem_pm.c:2:
+ * SPDX-License-Identifier: MIT

-:769: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#769: FILE: drivers/gpu/drm/i915/i915_gem_pm.h:1:
+/*

-:770: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#770: FILE: drivers/gpu/drm/i915/i915_gem_pm.h:2:
+ * SPDX-License-Identifier: MIT

-:803: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#803: FILE: drivers/gpu/drm/i915/test_i915_gem_pm_standalone.c:1:
+/*

-:804: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#804: FILE: drivers/gpu/drm/i915/test_i915_gem_pm_standalone.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 7 warnings, 0 checks, 764 lines checked
81e689f91366 drm/i915: Guard unpark/park with the gt.active_mutex
-:62: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#62: FILE: drivers/gpu/drm/i915/i915_drv.h:2012:
+		struct mutex active_mutex;

-:206: WARNING:MEMORY_BARRIER: memory barrier without comment
#206: FILE: drivers/gpu/drm/i915/i915_gem_pm.c:195:
+		smp_mb__before_atomic();

total: 0 errors, 1 warnings, 1 checks, 320 lines checked
813a6beabd0d drm/i915/selftests: Take GEM runtime wakeref
00464cbffc7a drm/i915: Pass intel_context to i915_request_create()
eeda44334ce5 drm/i915/gvt: Pin the per-engine GVT shadow contexts
1b6f6cddd7c4 drm/i915: Explicitly pin the logical context for execbuf
fcd27603aec2 drm/i915: Export intel_context_instance()
3b7120afe774 drm/i915/selftests: Use the real kernel context for sseu isolation tests
b99793a93604 drm/i915/selftests: Pass around intel_context for sseu
995399ebe6ae drm/i915: Pass intel_context to intel_context_pin_lock()
dec01d2d4aa7 drm/i915: Split engine setup/init into two phases
a40d0de34728 drm/i915: Switch back to an array of logical per-engine HW contexts
-:340: WARNING:LINE_SPACING: Missing a blank line after declarations
#340: FILE: drivers/gpu/drm/i915/i915_gem_context.h:217:
+		struct i915_gem_engines *e = rcu_dereference(ctx->engines);
+		if (likely(idx < e->num_engines && e->engines[idx]))

total: 0 errors, 1 warnings, 0 checks, 889 lines checked
8fcd1ab51436 drm/i915: Move i915_request_alloc into selftests/
-:262: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#262: 
new file mode 100644

-:267: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#267: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.c:1:
+/*

-:268: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#268: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.c:2:
+ * SPDX-License-Identifier: MIT

-:312: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#312: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.h:1:
+/*

-:313: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#313: FILE: drivers/gpu/drm/i915/selftests/igt_gem_utils.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 392 lines checked
206ad765f3d2 drm/i915: Allow a context to define its set of engines
-:402: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#402: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

-:402: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#402: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

-:402: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues
#402: FILE: drivers/gpu/drm/i915/i915_utils.h:107:
+#define check_struct_size(p, member, n, sz) \
+	likely(__check_struct_size(sizeof(*(p)), \
+				   sizeof(*(p)->member) + __must_be_array((p)->member), \
+				   n, sz))

total: 0 errors, 0 warnings, 3 checks, 403 lines checked
266e99111426 drm/i915: Allow userspace to clone contexts on creation
-:183: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#183: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1935:
+#define MAP(x, y) [ilog2(I915_CONTEXT_CLONE_##x)] = y

total: 1 errors, 0 warnings, 0 checks, 235 lines checked
ed63d4481857 drm/i915: Load balancing across a virtual engine
3c8fb3d139bb drm/i915: Extend execution fence to support a callback
cd0e579a0cda drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h
-:652: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#652: 
new file mode 100644

-:657: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#657: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:1:
+/*

-:658: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#658: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:2:
+ * SPDX-License-Identifier: MIT

-:912: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#912: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:1:
+/*

-:913: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#913: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 729 lines checked
dd039722b189 drm/i915/execlists: Virtual engine bonding
57e7c5c70ad5 drm/i915: Allow specification of parallel execbuf