[Intel-gfx] [PATCH 1/9] drm/i915: rename raw reg access functions

kbuild test robot lkp at intel.com
Tue Mar 26 04:18:12 UTC 2019


Hi Daniele,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190325]
[cannot apply to v5.1-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniele-Ceraolo-Spurio/more-uncore-rework/20190326-110805
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x003-201912 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

    ^~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   arch/x86/include/asm/io.h:59:17: error: conflicting types for 'readl'
    build_mmio_read(readl, "l", unsigned int, "=r", :"memory")
                    ^
   arch/x86/include/asm/io.h:48:20: note: in definition of macro 'build_mmio_read'
    static inline type name(const volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:223:9: note: previous implicit declaration of 'readl' was here
     return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
            ^
   drivers/gpu/drm/i915/intel_uncore.h:234:1: note: in expansion of macro '__raw_read'
    __raw_read(32, l)
    ^~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   arch/x86/include/asm/io.h:65:18: warning: conflicting types for 'writeb'
    build_mmio_write(writeb, "b", unsigned char, "q", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:65:18: error: static declaration of 'writeb' follows non-static declaration
    build_mmio_write(writeb, "b", unsigned char, "q", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writeb' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu/drm/i915/intel_uncore.h:237:1: note: in expansion of macro '__raw_write'
    __raw_write(8, b)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   arch/x86/include/asm/io.h:66:18: warning: conflicting types for 'writew'
    build_mmio_write(writew, "w", unsigned short, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:66:18: error: static declaration of 'writew' follows non-static declaration
    build_mmio_write(writew, "w", unsigned short, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writew' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu/drm/i915/intel_uncore.h:238:1: note: in expansion of macro '__raw_write'
    __raw_write(16, w)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   arch/x86/include/asm/io.h:67:18: warning: conflicting types for 'writel'
    build_mmio_write(writel, "l", unsigned int, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:67:18: error: static declaration of 'writel' follows non-static declaration
    build_mmio_write(writel, "l", unsigned int, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writel' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu/drm/i915/intel_uncore.h:239:1: note: in expansion of macro '__raw_write'
    __raw_write(32, l)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
>> arch/x86/include/asm/io.h:97:17: error: conflicting types for 'readq'
    build_mmio_read(readq, "q", u64, "=r", :"memory")
                    ^
   arch/x86/include/asm/io.h:48:20: note: in definition of macro 'build_mmio_read'
    static inline type name(const volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:223:9: note: previous implicit declaration of 'readq' was here
     return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
            ^
   drivers/gpu/drm/i915/intel_uncore.h:235:1: note: in expansion of macro '__raw_read'
    __raw_read(64, q)
    ^~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu/drm/i915/i915_vma.h:28,
                    from drivers/gpu/drm/i915/intel_guc.h:36,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
>> arch/x86/include/asm/io.h:99:18: warning: conflicting types for 'writeq'
    build_mmio_write(writeq, "q", u64, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
>> arch/x86/include/asm/io.h:99:18: error: static declaration of 'writeq' follows non-static declaration
    build_mmio_write(writeq, "q", u64, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writeq' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu/drm/i915/intel_uncore.h:240:1: note: in expansion of macro '__raw_write'
    __raw_write(64, q)
    ^~~~~~~~~~~
   cc1: some warnings being treated as errors
--
                    ^
   arch/x86/include/asm/io.h:48:20: note: in definition of macro 'build_mmio_read'
    static inline type name(const volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:223:9: note: previous implicit declaration of 'readl' was here
     return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
            ^
   drivers/gpu//drm/i915/intel_uncore.h:234:1: note: in expansion of macro '__raw_read'
    __raw_read(32, l)
    ^~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu//drm/i915/i915_vma.h:28,
                    from drivers/gpu//drm/i915/intel_guc.h:36,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   arch/x86/include/asm/io.h:65:18: warning: conflicting types for 'writeb'
    build_mmio_write(writeb, "b", unsigned char, "q", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:65:18: error: static declaration of 'writeb' follows non-static declaration
    build_mmio_write(writeb, "b", unsigned char, "q", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writeb' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu//drm/i915/intel_uncore.h:237:1: note: in expansion of macro '__raw_write'
    __raw_write(8, b)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu//drm/i915/i915_vma.h:28,
                    from drivers/gpu//drm/i915/intel_guc.h:36,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   arch/x86/include/asm/io.h:66:18: warning: conflicting types for 'writew'
    build_mmio_write(writew, "w", unsigned short, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:66:18: error: static declaration of 'writew' follows non-static declaration
    build_mmio_write(writew, "w", unsigned short, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writew' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu//drm/i915/intel_uncore.h:238:1: note: in expansion of macro '__raw_write'
    __raw_write(16, w)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu//drm/i915/i915_vma.h:28,
                    from drivers/gpu//drm/i915/intel_guc.h:36,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   arch/x86/include/asm/io.h:67:18: warning: conflicting types for 'writel'
    build_mmio_write(writel, "l", unsigned int, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   arch/x86/include/asm/io.h:67:18: error: static declaration of 'writel' follows non-static declaration
    build_mmio_write(writel, "l", unsigned int, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writel' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu//drm/i915/intel_uncore.h:239:1: note: in expansion of macro '__raw_write'
    __raw_write(32, l)
    ^~~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu//drm/i915/i915_vma.h:28,
                    from drivers/gpu//drm/i915/intel_guc.h:36,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
>> arch/x86/include/asm/io.h:97:17: error: conflicting types for 'readq'
    build_mmio_read(readq, "q", u64, "=r", :"memory")
                    ^
   arch/x86/include/asm/io.h:48:20: note: in definition of macro 'build_mmio_read'
    static inline type name(const volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:223:9: note: previous implicit declaration of 'readq' was here
     return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
            ^
   drivers/gpu//drm/i915/intel_uncore.h:235:1: note: in expansion of macro '__raw_read'
    __raw_read(64, q)
    ^~~~~~~~~~
   In file included from include/linux/io.h:25:0,
                    from include/linux/io-mapping.h:24,
                    from drivers/gpu//drm/i915/i915_vma.h:28,
                    from drivers/gpu//drm/i915/intel_guc.h:36,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
>> arch/x86/include/asm/io.h:99:18: warning: conflicting types for 'writeq'
    build_mmio_write(writeq, "q", u64, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
>> arch/x86/include/asm/io.h:99:18: error: static declaration of 'writeq' follows non-static declaration
    build_mmio_write(writeq, "q", u64, "r", :"memory")
                     ^
   arch/x86/include/asm/io.h:53:20: note: in definition of macro 'build_mmio_write'
    static inline void name(type val, volatile void __iomem *addr) \
                       ^~~~
   In file included from drivers/gpu//drm/i915/intel_guc.h:28:0,
                    from drivers/gpu//drm/i915/intel_uc.h:27,
                    from drivers/gpu//drm/i915/intel_uc.c:25:
   drivers/gpu//drm/i915/intel_uncore.h:230:2: note: previous implicit declaration of 'writeq' was here
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
   drivers/gpu//drm/i915/intel_uncore.h:240:1: note: in expansion of macro '__raw_write'
    __raw_write(64, q)
    ^~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/readq +97 arch/x86/include/asm/io.h

93093d099 arch/x86/include/asm/io.h Ingo Molnar     2008-11-30   96  
6469a0ee0 arch/x86/include/asm/io.h Andy Shevchenko 2018-05-15  @97  build_mmio_read(readq, "q", u64, "=r", :"memory")
6469a0ee0 arch/x86/include/asm/io.h Andy Shevchenko 2018-05-15   98  build_mmio_read(__readq, "q", u64, "=r", )
6469a0ee0 arch/x86/include/asm/io.h Andy Shevchenko 2018-05-15  @99  build_mmio_write(writeq, "q", u64, "r", :"memory")
6469a0ee0 arch/x86/include/asm/io.h Andy Shevchenko 2018-05-15  100  build_mmio_write(__writeq, "q", u64, "r", )
c1f64a580 include/asm-x86/io.h      Linus Torvalds  2008-05-27  101  

:::::: The code at line 97 was first introduced by commit
:::::: 6469a0ee0a06b2ea1f5afbb1d5a3feed017d4c7a x86/io: Define readq()/writeq() to use 64-bit type

:::::: TO: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
:::::: CC: Ingo Molnar <mingo at kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 24963 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190326/c9351be6/attachment-0001.gz>


More information about the Intel-gfx mailing list