[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for more uncore rework

[Patchwork]

== Series Details ==

Series: more uncore rework
URL   : https://patchwork.freedesktop.org/series/58550/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6e25d35e2cc9 drm/i915: rename raw reg access functions
-:126: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#126: FILE: drivers/gpu/drm/i915/intel_uncore.c:455:
+		dev_priv->edram_cap = __raw_uncore_read32(&dev_priv->uncore,
 							HSW_EDRAM_CAP);

-:298: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#298: FILE: drivers/gpu/drm/i915/intel_uncore.h:232:
+}
+__raw_read(8, b)

total: 0 errors, 0 warnings, 2 checks, 262 lines checked
166116555629 drm/i915: add HAS_FORCEWAKE flag to uncore
77645a276eb5 drm/i915: add uncore flags for unclaimed mmio
2cf0b14f6229 drm/i915: take a ref to the rpm in the uncore structure
-:45: CHECK:LINE_SPACING: Please don't use multiple blank lines
#45: FILE: drivers/gpu/drm/i915/intel_drv.h:2293:
+
+

total: 0 errors, 0 warnings, 1 checks, 111 lines checked
b1d91e233942 drm/i915: switch uncore mmio funcs to use intel_uncore
-:44: WARNING:LONG_LINE: line over 100 characters
#44: FILE: drivers/gpu/drm/i915/i915_drv.h:3477:
+#define I915_WRITE16_NOTRACE(reg__, val__) __I915_REG_OP(write16_notrace, dev_priv, (reg__), (val__))

-:229: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#229: FILE: drivers/gpu/drm/i915/intel_uncore.h:254:
+#define __uncore_read(name__, x__, s__, trace__) \
+static inline u##x__ intel_uncore_##name__(struct intel_uncore *uncore, \
+					   i915_reg_t reg) \
+{ \
+	return uncore->funcs.mmio_read##s__(uncore, reg, (trace__)); \
+}

-:275: WARNING:LINE_SPACING: Missing a blank line after declarations
#275: FILE: drivers/gpu/drm/i915/intel_uncore.h:300:
+	u32 upper, lower, old_upper, loop = 0;
+	upper = intel_uncore_read(uncore, upper_reg);

total: 1 errors, 2 warnings, 0 checks, 295 lines checked
443cb3ccc31f drm/i915: switch intel_uncore_forcewake_for_reg to intel_uncore
fc9304b17a6a drm/i915: intel_wait_for_register_fw to uncore
-:415: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#415: FILE: drivers/gpu/drm/i915/intel_uncore.h:209:
 }
+int __intel_wait_for_register_fw(struct intel_uncore *uncore,

total: 0 errors, 0 warnings, 1 checks, 364 lines checked
7c8747a40025 drm/i915: switch intel_wait_for_register to uncore
-:104: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#104: FILE: drivers/gpu/drm/i915/intel_cdclk.c:983:
+	if (intel_wait_for_register(&dev_priv->uncore,
 				   LCPLL1_CTL, LCPLL_PLL_LOCK, 0,

-:734: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#734: FILE: drivers/gpu/drm/i915/intel_uncore.c:1835:
+int __intel_wait_for_register(struct intel_uncore *uncore,
 			    i915_reg_t reg,

-:829: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#829: FILE: drivers/gpu/drm/i915/vlv_dsi.c:357:
+		if (intel_wait_for_register(&dev_priv->uncore,
 				MIPI_CTRL(port), GLK_MIPIIO_PORT_POWERED,

-:838: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#838: FILE: drivers/gpu/drm/i915/vlv_dsi.c:381:
+		if (intel_wait_for_register(&dev_priv->uncore,
 				MIPI_CTRL(port), GLK_PHY_STATUS_PORT_READY,

-:847: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#847: FILE: drivers/gpu/drm/i915/vlv_dsi.c:407:
+			if (intel_wait_for_register(&dev_priv->uncore,
 				MIPI_CTRL(port), GLK_ULPS_NOT_ACTIVE, 0, 20))

-:856: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#856: FILE: drivers/gpu/drm/i915/vlv_dsi.c:431:
+		if (intel_wait_for_register(&dev_priv->uncore,
 				MIPI_CTRL(port), GLK_DATA_LANE_STOP_STATE,

-:865: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#865: FILE: drivers/gpu/drm/i915/vlv_dsi.c:439:
+		if (intel_wait_for_register(&dev_priv->uncore,
 				BXT_MIPI_PORT_CTRL(port), AFE_LATCHOUT,

total: 0 errors, 0 warnings, 7 checks, 727 lines checked
65409c86a0d0 drm/i915: take a reference to uncore in the engine and use it
-:76: CHECK:SPACING: No space is necessary after a cast
#76: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1153:
+			ee->faddr |= (u64) ENGINE_READ(engine, RING_DMA_FADD_UDW) << 32;

-:77: CHECK:SPACING: No space is necessary after a cast
#77: FILE: drivers/gpu/drm/i915/i915_gpu_error.c:1154:
+			ee->bbaddr |= (u64) ENGINE_READ(engine, RING_BBADDR_UDW) << 32;

-:390: WARNING:LONG_LINE: line over 100 characters
#390: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:1337:
+		   ENGINE_READ(engine, RING_CTL) & (RING_WAIT | RING_WAIT_SEMAPHORE) ? " [waiting]" : "");

-:540: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#540: FILE: drivers/gpu/drm/i915/intel_lrc.c:2078:
+	ENGINE_WRITE(engine, RING_IMR,
 		       ~(engine->irq_enable_mask | engine->irq_keep_mask));

-:996: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#996: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:48:
+#define __ENGINE_READ_OP(op__, engine__, reg__) \
+	__ENGINE_REG_OP(op__, (engine__), reg__((engine__)->mmio_base))

-:1008: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#1008: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:56:
+#define ENGINE_READ64(engine__, lower_reg__, upper_reg__) \
+	__ENGINE_REG_OP(read64_2x32, (engine__), \
+			lower_reg__((engine__)->mmio_base), \
+			upper_reg__((engine__)->mmio_base))

-:1015: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#1015: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:61:
+#define ENGINE_READ_IDX(engine__, reg__, idx__) \
+	__ENGINE_REG_OP(read, (engine__), reg__((engine__)->mmio_base, (idx__)))

-:1020: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#1020: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:64:
+#define __ENGINE_WRITE_OP(op__, engine__, reg__, val__) \
+	__ENGINE_REG_OP(op__, (engine__), reg__((engine__)->mmio_base), (val__))

total: 0 errors, 1 warnings, 7 checks, 914 lines checked