[Intel-gfx] [PATCH] drm/i915: move the edram detection out of uncore init

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 28 20:43:45 UTC 2019


Quoting Daniele Ceraolo Spurio (2019-03-28 17:45:32)
> edram is not part of uncore and there is no requirement for the
> detection to be done before we initialize the uncore functions. The
> first check on HAS_EDRAM is in the ggtt_init path, so move it to
> i915_driver_init_hw, where other dram-related detection happens.
> 
> While at it, save the size in MB instead of the capabilities because the
> size is the only thing we look at outside of the init function.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

I'm devoid of good suggestions as to where better to place it. Certainly
we don't want it in i915_drv.c, maybe intel_cache_topology.c.

Anyway, that doesn't detract from the merits of this patch,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list