[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine relative MMIO (rev3)

Patchwork patchwork at emeril.freedesktop.org
Sat Mar 30 00:57:28 UTC 2019


== Series Details ==

Series: drm/i915: Engine relative MMIO (rev3)
URL   : https://patchwork.freedesktop.org/series/57117/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a3f3b4a23cc5 drm/i915: Engine relative MMIO
-:89: ERROR:SPACING: space prohibited after that open parenthesis '('
#89: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:223:
+	CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,

-:90: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#90: FILE: drivers/gpu/drm/i915/i915_cmd_parser.c:224:
+	CMD(  __MI_LOAD_REGISTER_IMM(1),        SMI,   !F,  0xFF,   W,
 	      .reg = { .offset = 1, .mask = 0x007FFFFC, .step = 2 }    ),

-:249: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#249: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
                                  	                ^

-:249: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#249: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:130:
+#define __MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
                                  	                    ^

-:251: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#251: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:132:
+#define   MI_LRI_ADD_CS_MMIO_START	(1<<19)
                                   	  ^

-:538: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#538: FILE: drivers/gpu/drm/i915/intel_ringbuffer.c:1771:
+	*cs++ = i915_get_lri_cmd(rq->engine, GEN7_L3LOG_SIZE/4);
 	                                                    ^

-:606: CHECK:CAMELCASE: Avoid CamelCase: <regLRI>
#606: FILE: drivers/gpu/drm/i915/selftests/intel_workarounds.c:490:
+		u32 regLRI = i915_get_lri_reg(engine, engine->whitelist.list[i].reg);

total: 1 errors, 0 warnings, 6 checks, 505 lines checked



More information about the Intel-gfx mailing list